[ https://issues.apache.org/jira/browse/CASSANDRA-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791395#comment-17791395 ]
Ekaterina Dimitrova edited comment on CASSANDRA-19001 at 11/30/23 1:16 AM: --------------------------------------------------------------------------- [5.0 Patch|https://github.com/ekaterinadimitrova2/cassandra/commit/613bb6d2cbc40924479eac044f78e0c4e584521b], [CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=19001-5.0-patch]- CircleCI is having a bad day, hitting concurrency limits (too many CI runs) and returning a lot of address already in use, OS errors. We've seen those before. I will check the failures one by one and rerun the tests tomorrow, but I wanted to leave the patch ready for review in the meantime so I can get feedback. Also, based on experience I am fairly sure the patch is not causing those issues. [~paulo], do you mind to review, please? I tested also locally with JRE/JDK 11 and 17. was (Author: e.dimitrova): [Patch|https://github.com/ekaterinadimitrova2/cassandra/commit/613bb6d2cbc40924479eac044f78e0c4e584521b], [CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=19001-5.0-patch]- CircleCI is having a bad day, hitting concurrency limits (too many CI runs) and returning a lot of address already in use, OS errors. We've seen those before. I will check the failures one by one and rerun the tests tomorrow, but I wanted to leave the patch ready for review in the meantime so I can get feedback. Also, based on experience I am fairly sure the patch is not causing those issues. [~paulo], do you mind to review, please? I tested also locally with JRE/JDK 11 and 17. > Check whether the startup warnings for unknown modules represent a legit > problem or cosmetic issue > -------------------------------------------------------------------------------------------------- > > Key: CASSANDRA-19001 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19001 > Project: Cassandra > Issue Type: Bug > Components: Local/Other > Reporter: Ekaterina Dimitrova > Assignee: Ekaterina Dimitrova > Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0-rc, 5.0.x, 5.x > > > During the 5.0 alpha 2 release > [vote|https://lists.apache.org/thread/lt3x0obr5cpbcydf5490pj6b2q0mz5zr], > [~paulo] raised the following concerns: > {code:java} > Launched a tarball-based 5.0-alpha2 container on top of > "eclipse-temurin:17-jre-focal" and the server starts up fine, can run > nodetool and cqlsh. > I got these seemingly harmless JDK17 warnings during startup and when > running nodetool (no warnings on JDK11): > WARNING: Unknown module: jdk.attach specified to --add-exports > WARNING: Unknown module: jdk.compiler specified to --add-exports > WARNING: Unknown module: jdk.compiler specified to --add-opens > WARNING: A terminally deprecated method in java.lang.System has been called > WARNING: System::setSecurityManager has been called by > org.apache.cassandra.security.ThreadAwareSecurityManager > (file:/opt/cassandra/lib/apache-cassandra-5.0-alpha2-SNAPSHOT.jar) > WARNING: Please consider reporting this to the maintainers of > org.apache.cassandra.security.ThreadAwareSecurityManager > WARNING: System::setSecurityManager will be removed in a future release > Anybody knows if these warnings are legit/expected ? We can create > follow-up tickets if needed. > $ java --version > openjdk 17.0.9 2023-10-17 > OpenJDK Runtime Environment Temurin-17.0.9+9 (build 17.0.9+9) > OpenJDK 64-Bit Server VM Temurin-17.0.9+9 (build 17.0.9+9, mixed mode, > sharing) > {code} > {code:java} > Clarification: - When running nodetool only the "Unknown module" warnings > show up. All warnings show up during startup.{code} > We need to verify whether this presents a real problem in the features where > those modules are expected to be used, or if it is a false alarm. > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org