arjunashok commented on code in PR #17: URL: https://github.com/apache/cassandra-analytics/pull/17#discussion_r1411436951
########## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/RecordWriter.java: ########## @@ -136,35 +185,122 @@ public StreamResult write(Iterator<Tuple2<DecoratedKey, Object[]>> sourceIterato } } + private Map<Range<BigInteger>, List<RingInstance>> taskTokenRangeMapping(TokenRangeMapping<RingInstance> tokenRange, + Range<BigInteger> taskTokenRange) + { + return tokenRange.getSubRanges(taskTokenRange).asMapOfRanges(); + } + + private Set<RingInstance> instancesFromMapping(Map<Range<BigInteger>, List<RingInstance>> mapping) + { + return mapping.values() + .stream() + .flatMap(Collection::stream) + .collect(Collectors.toSet()); + } + + /** + * Creates a new session if we have the current token range intersecting the ranges from write replica-set. + * If we do find the need to split a range into sub-ranges, we create the corresponding session for the sub-range + * if the token from the row data belongs to the range. + */ + private StreamSession maybeCreateStreamSession(TaskContext taskContext, + StreamSession streamSession, + Tuple2<DecoratedKey, Object[]> rowData, + Set<Range<BigInteger>> newRanges, + ReplicaAwareFailureHandler<RingInstance> failureHandler) throws IOException + { + BigInteger token = rowData._1().getToken(); + Range<BigInteger> tokenRange = getTokenRange(taskContext); + + Preconditions.checkState(tokenRange.contains(token), + String.format("Received Token %s outside of expected range %s", token, tokenRange)); + + // token range for this partition is not among the write-replica-set ranges + if (!newRanges.contains(tokenRange)) Review Comment: Makes sense. Pulled this out of the loop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org