frankgh commented on code in PR #19:
URL:
https://github.com/apache/cassandra-analytics/pull/19#discussion_r1414336436
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/CassandraDataLayer.java:
##########
@@ -343,7 +346,7 @@ private CompletionStage<Map<String, AvailabilityHint>>
createSnapshot(RingRespon
snapshotName, keyspace, table, datacenter,
ringEntry.fqdn());
SidecarInstance sidecarInstance = new
SidecarInstanceImpl(ringEntry.fqdn(), sidecarClientConfig.effectivePort());
createSnapshotFuture = sidecar
- .createSnapshot(sidecarInstance,
keyspace, table, snapshotName)
+ .createSnapshot(sidecarInstance,
maybeQuotedKeyspace, maybeQuotedTable, snapshotName)
Review Comment:
however, the cleanup of snapshots happens on a different thread, if an
exception occurs before the bridge has been initialized (i.e an error occurs
when getting the cassandra version `String cassandraVersion =
getEffectiveCassandraVersionForRead(clusterConfig, nodeSettings);` ) then the
shutdown hook will be triggered and it will try to cleanup snapshots, even
though the snapshot was never created in the first place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
