frankgh commented on code in PR #20:
URL:
https://github.com/apache/cassandra-analytics/pull/20#discussion_r1419969685
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraClusterInfo.java:
##########
@@ -535,6 +548,15 @@ protected boolean isReplacement(RingEntry ringEntry)
return false;
}
+ protected CassandraBridge bridge()
+ {
+ if (bridge == null)
+ {
+ bridge = CassandraBridgeFactory.get(getLowestCassandraVersion());
Review Comment:
yeah, having a local cache saves look ups from the map. But lookups are fast
anyway, so I think we can remove the local field used as a cache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
