[ https://issues.apache.org/jira/browse/CASSANDRA-19196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796395#comment-17796395 ]
Stefan Miklosovic edited comment on CASSANDRA-19196 at 12/13/23 6:32 PM: ------------------------------------------------------------------------- I check the PR and what would be cool is to not depend on "uname", there is also a lot of custom logic around running a process etc. We are trying to get rid of sigar (CASSANDRA-16565) and we seem to go to change it for oshi lib. Sigar is old, not maintained etc, it bundles a lot of libs we dont need ... By replacing it for oshi we can save few megs when it comes to distribution tarball ... What would be nice is to investigate the this specifically (1), I am not sure what string it would return but if it was kernel's version we can parse, we could throw away a lot of things and "unify" how we get stuff like this from underlying system. (1) https://github.com/oshi/oshi/blob/master/oshi-core/src/main/java/oshi/software/os/OperatingSystem.java#L130 EDIT they seem to call "uname" as well https://github.com/oshi/oshi/blob/master/oshi-core/src/main/java/oshi/software/os/linux/LinuxOperatingSystem.java#L197 Too bad they do not seem to parse kernel version as far as I see. was (Author: smiklosovic): I check the PR and what would be cool is to not depend on "uname", there is also a lot of custom logic around running a process etc. We are trying to get rid of sigar (CASSANDRA-16565) and we seem to go to change it for oshi lib. Sigar is old, not maintained etc, it bundles a lot of libs we dont need ... By replacing it for oshi we can save few megs when it comes to distribution tarball ... What would be nice is to investigate the this specifically (1), I am not sure what string it would return but if it was kernel's version we can parse, we could throw away a lot of things and "unify" how we get stuff like this from underlying system. (1) https://github.com/oshi/oshi/blob/master/oshi-core/src/main/java/oshi/software/os/OperatingSystem.java#L130 > Don't allow to enable direct i/o with broken kernels > ---------------------------------------------------- > > Key: CASSANDRA-19196 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19196 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Local Write-Read Paths > Reporter: Jacek Lewandowski > Assignee: Jacek Lewandowski > Priority: Normal > Fix For: 5.0-rc, 5.1 > > > https://lwn.net/Articles/954285/, found by [~rustyrazorblade] -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org