frankgh commented on code in PR #27:
URL:
https://github.com/apache/cassandra-analytics/pull/27#discussion_r1432995042
##########
cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/analytics/ResiliencyTestBase.java:
##########
@@ -375,10 +375,22 @@ protected void bulkWriteData(ConsistencyLevel writeCL,
QualifiedName schema)
if (!completed)
{
process.destroyForcibly();
- finishLatch.await(10, TimeUnit.MINUTES);
+ // The process doesn't necessarily finish right after
destroyForcibly, but will exit.
+ process.waitFor(1, TimeUnit.MINUTES);
Review Comment:
maybe add a comment on why we only let the spawned spark process run for 1
minute. And the `errorMessage` in line 380 will need to be updated as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
