frankgh commented on code in PR #28: URL: https://github.com/apache/cassandra-analytics/pull/28#discussion_r1437860156
########## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/TableSchema.java: ########## @@ -136,11 +136,11 @@ private static List<SqlToCqlTypeConverter.Converter<?>> getConverters(StructType .map(fieldName -> { if (fieldName.equals(ttlOption.columnName())) { - return SqlToCqlTypeConverter.getIntegerConverter(); + return SqlToCqlTypeConverter.integerConverter(); } if (fieldName.equals(timestampOption.columnName())) { - return SqlToCqlTypeConverter.getLongConverter(); + return SqlToCqlTypeConverter.microsecondsTimestampConverter(); Review Comment: timestamp is expected to be in microseconds -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org