[ https://issues.apache.org/jira/browse/CASSANDRA-19104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803894#comment-17803894 ]
Leo Toff commented on CASSANDRA-19104: -------------------------------------- Thank y'all for reviewing and merging the changes. [~bschoeni] and [~smiklosovic] please review the second PR in the series: [https://github.com/apache/cassandra/pull/3031] This PR makes human-readable formatting default in `nodetool tablestats`. Are there unit tests and d-tests that I missed? > Standardize tablestats formatting and data units > ------------------------------------------------ > > Key: CASSANDRA-19104 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19104 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool > Reporter: Brad Schoening > Assignee: Leo Toff > Priority: Normal > Fix For: 5.1 > > Time Spent: 4.5h > Remaining Estimate: 0h > > Tablestats reports output in plaintext, JSON or YAML. The human readable > output currently has a mix of KiB, bytes with inconsistent spacing > Simplify and default output to 'human readable'. Machine readable output is > available as an option and the current mixed output formatting is neither > friendly for human or machine reading and can be replaced. > !image-2023-11-27-13-49-14-247.png! > *Not a goal now (consider a follow up Jira):* > Fix inconsistencies with KiB/MiB/GiB and KB/MB/GB formatting: > * gcstats - uses MB > * getcompactionthroughput - uses MB/s > * getstreamthroughput - uses MB/s > * info - uses MiB/GiB -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org