[ https://issues.apache.org/jira/browse/CASSANDRA-18714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807197#comment-17807197 ]
Stefan Miklosovic commented on CASSANDRA-18714: ----------------------------------------------- *CASSANDRA-18714-5.0-squashed* {noformat} java17_pre-commit_tests 3h 47m 24s ✓ j17_build 4m 34s ✓ j17_cqlsh_dtests_py3 5m 39s ✓ j17_cqlsh_dtests_py311 6m 30s ✓ j17_cqlsh_dtests_py311_vnode 6m 20s ✓ j17_cqlsh_dtests_py38 6m 8s ✓ j17_cqlsh_dtests_py38_vnode 6m 5s ✓ j17_cqlsh_dtests_py3_vnode 6m 19s ✓ j17_cqlshlib_cython_tests 7m 57s ✓ j17_cqlshlib_tests 7m 6s ✓ j17_dtests 33m 38s ✓ j17_jvm_dtests 18m 16s ✓ j17_jvm_dtests_vnode 14m 46s ✓ j17_unit_tests 14m 47s ✓ j17_unit_tests_repeat 24m 34s ✓ j17_utests_oa 13m 23s ✓ j17_utests_oa_repeat 24m 45s ✕ j17_dtests_vnode 34m 3s bootstrap_test.TestBootstrap test_decommissioned_wiped_node_can_join java17_separate_tests java11_pre-commit_tests 3h 47m 27s java11_separate_tests {noformat} [java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3775/workflows/66b2154b-4e81-47c6-9b1d-630b40d02cdd] [java17_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3775/workflows/40726445-3bf5-4772-9d9e-ac23c9c50fec] [java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3775/workflows/96dec147-6f80-440c-a0a1-aabdff6e6a0e] [java11_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3775/workflows/83242744-11a1-4cf1-826d-d786d30cb3ca] > Expand CQLSSTableWriter to write SSTable-attached secondary indexes > ------------------------------------------------------------------- > > Key: CASSANDRA-18714 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18714 > Project: Cassandra > Issue Type: Improvement > Components: Feature/SAI, Tool/bulk load > Reporter: Caleb Rackliffe > Assignee: Stefan Miklosovic > Priority: Normal > Fix For: 5.0-rc, 5.x > > Attachments: client-mode-cqlsstablewriter-tests.patch > > Time Spent: 12h > Remaining Estimate: 0h > > {{CQLSSTableWriter}} currently has no way of writing any secondary indexes > inline as it writes the core SSTable components. With SAI, this has become > tractable problem, and we should be able to enhance both it and > {{SSTableImporter}} to handle cases where we might want to write SSTables > somewhere in bulk (and in parallel) and then import them without waiting for > index building on import. It would require the following changes: > 1.) {{CQLSSTableWriter}} must accept 2i definitions on top of its current > table schema definition. Once added to the schema, any {{ColumnFamilyStore}} > instances opened will have those 2i defined in their index managers. > 2.) All {{AbstractSSTableSimpleWriter}} instances must register index groups, > allowing the proper {{SSTableFlushObservers}} to be attached to > {{SSTableWriter}}. Once this is done, SAI (and any other SSTable-attached > indexes) components will be built incrementally along w/ the SSTable data > file, and will be finalized when the newly written SSTable is finalized. > 3.) Provide an example (in a unit test?) of how a third-party tool might, > assuming access to the right C* JAR, validate/checksum SAI components outside > C* proper. > 4.) {{SSTableImporter}} should have two new options: > a.) an option that fails import if any SSTable-attached 2i must be built > (i.e. has not already been built and brought along w/ the other new SSTable > components) > b.) an option that allows us to bypass full checksum validation on > imported/already-built SSTable-attached indexes (assuming they have just been > written by {{CQLSSTableWriter}}) -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org