[ https://issues.apache.org/jira/browse/CASSANDRA-18714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809300#comment-17809300 ]
Stefan Miklosovic edited comment on CASSANDRA-18714 at 1/22/24 8:47 AM: ------------------------------------------------------------------------ *CASSANDRA-18714-trunk* {noformat} java17_pre-commit_tests j17_dtests transient_replication_ring_test.TestTransientReplicationRing test_move_forwards_and_cleanup j17_jvm_dtests org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest testEndpointVerificationEnabledIpNotInSAN j17_jvm_dtests_vnode org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest testOptionalMtlsModeDoNotAllowNonSSLConnections j17_utests_oa org.apache.cassandra.audit.AuditLoggerAuthTest testUNAUTHORIZED_ATTEMPTAuditing org.apache.cassandra.audit.AuditLoggerAuthTest testCqlLoginAuditing java11_pre-commit_tests j11_simulator_dtests org.apache.cassandra.simulator.test.HarrySimulatorTest test j17_jvm_dtests org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest unencryptedNativeConnectionNotlisteningOnTlsPortTest j17_jvm_dtests_vnode org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest testEndpointVerificationEnabledIpNotInSAN {noformat} [java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3791/workflows/4d8c81d6-3ef6-479f-bc50-b5515905f617] [java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3791/workflows/415b5e27-012d-4925-bb7d-cf4ccc6375e4] I do not see anything out of ordinary, AuditLoggerAuthTest passes locally, NativeTransportEncryptionOptionsTest is just flaky. was (Author: smiklosovic): *CASSANDRA-18714-trunk* {noformat} java17_pre-commit_tests j17_dtests transient_replication_ring_test.TestTransientReplicationRing test_move_forwards_and_cleanup j17_jvm_dtests org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest testEndpointVerificationEnabledIpNotInSAN j17_jvm_dtests_vnode org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest testOptionalMtlsModeDoNotAllowNonSSLConnections j17_utests_oa org.apache.cassandra.audit.AuditLoggerAuthTest testUNAUTHORIZED_ATTEMPTAuditing org.apache.cassandra.audit.AuditLoggerAuthTest testCqlLoginAuditing java11_pre-commit_tests j11_simulator_dtests org.apache.cassandra.simulator.test.HarrySimulatorTest test j17_jvm_dtests org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest unencryptedNativeConnectionNotlisteningOnTlsPortTest j17_jvm_dtests_vnode org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest testEndpointVerificationEnabledIpNotInSAN {noformat} [java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3791/workflows/4d8c81d6-3ef6-479f-bc50-b5515905f617] [java17_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3791/workflows/0e0da2f6-6c97-410a-ae87-3c30c31dbd29] [java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3791/workflows/415b5e27-012d-4925-bb7d-cf4ccc6375e4] [java11_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3791/workflows/e195b29a-e4de-4bfa-ad94-2ee2006001a5] > Expand CQLSSTableWriter to write SSTable-attached secondary indexes > ------------------------------------------------------------------- > > Key: CASSANDRA-18714 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18714 > Project: Cassandra > Issue Type: Improvement > Components: Feature/SAI, Tool/bulk load > Reporter: Caleb Rackliffe > Assignee: Stefan Miklosovic > Priority: Normal > Fix For: 5.0-rc, 5.x > > Attachments: client-mode-cqlsstablewriter-tests.patch > > Time Spent: 13.5h > Remaining Estimate: 0h > > {{CQLSSTableWriter}} currently has no way of writing any secondary indexes > inline as it writes the core SSTable components. With SAI, this has become > tractable problem, and we should be able to enhance both it and > {{SSTableImporter}} to handle cases where we might want to write SSTables > somewhere in bulk (and in parallel) and then import them without waiting for > index building on import. It would require the following changes: > 1.) {{CQLSSTableWriter}} must accept 2i definitions on top of its current > table schema definition. Once added to the schema, any {{ColumnFamilyStore}} > instances opened will have those 2i defined in their index managers. > 2.) All {{AbstractSSTableSimpleWriter}} instances must register index groups, > allowing the proper {{SSTableFlushObservers}} to be attached to > {{SSTableWriter}}. Once this is done, SAI (and any other SSTable-attached > indexes) components will be built incrementally along w/ the SSTable data > file, and will be finalized when the newly written SSTable is finalized. > 3.) Provide an example (in a unit test?) of how a third-party tool might, > assuming access to the right C* JAR, validate/checksum SAI components outside > C* proper. > 4.) {{SSTableImporter}} should have two new options: > a.) an option that fails import if any SSTable-attached 2i must be built > (i.e. has not already been built and brought along w/ the other new SSTable > components) > b.) an option that allows us to bypass full checksum validation on > imported/already-built SSTable-attached indexes (assuming they have just been > written by {{CQLSSTableWriter}}) -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org