frankgh commented on code in PR #36:
URL:
https://github.com/apache/cassandra-analytics/pull/36#discussion_r1469935126
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkSparkConf.java:
##########
@@ -147,9 +143,7 @@ public BulkSparkConf(SparkConf conf, Map<String, String>
options)
this.consistencyLevel =
ConsistencyLevel.CL.valueOf(MapUtils.getOrDefault(options,
WriterOptions.BULK_WRITER_CL.name(), "EACH_QUORUM"));
this.localDC = MapUtils.getOrDefault(options,
WriterOptions.LOCAL_DC.name(), null);
this.numberSplits = MapUtils.getInt(options,
WriterOptions.NUMBER_SPLITS.name(), DEFAULT_NUM_SPLITS, "number of splits");
- this.rowBufferMode = MapUtils.getEnumOption(options,
WriterOptions.ROW_BUFFER_MODE.name(), DEFAULT_ROW_BUFFER_MODE, "row buffering
mode");
- this.sstableDataSizeInMB = MapUtils.getInt(options,
WriterOptions.SSTABLE_DATA_SIZE_IN_MB.name(), 160, "sstable data size in MB");
- this.sstableBatchSize = MapUtils.getInt(options,
WriterOptions.BATCH_SIZE.name(), 1_000_000, "sstable batch size");
+ this.sstableDataSizeInMB = MapUtils.getInt(options,
WriterOptions.SSTABLE_DATA_SIZE_IN_MB.name(), DEFAULT_SSTABLE_DATA_SIZE_IN_MB,
"sstable data size in mebibytes");
Review Comment:
+1 that makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
