[ 
https://issues.apache.org/jira/browse/CASSANDRA-19201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818038#comment-17818038
 ] 

Stefan Miklosovic edited comment on CASSANDRA-19201 at 2/16/24 4:36 PM:
------------------------------------------------------------------------

[~bschoeni]  well, it helped, but there are few more failures (1)

[https://app.circleci.com/pipelines/github/instaclustr/cassandra/3887/workflows/f5e8d089-39ab-4760-a869-f480a948bbfd/jobs/193078/parallel-runs/21?filterBy=FAILED]

Please take a look, thank you very much

However, I think that it wont be so easy, because Python driver is using Shell 
so it wont match the arguments which I fixed 

 
{noformat}
  ✕ j17_cqlsh_dtests_py311                           6m 52s
      cqlsh_tests.test_cqlsh_copy.TestCqlshCopy 
test_round_trip_with_authentication
        AssertionError: Failed to import 10 rows
          STDOUT:
          
          Warning: Using a password on the command line interface can be 
insecure.
          Recommendation: use the credentials file to securely provide the 
password.
          
          Using CQL driver: <module 'cassandra' from 
'/home/cassandra/cassandra/bin/../lib/cassandra-driver-internal-only-3.29.0.zip/cassandra-driver-3.29.0/cassandra/__init__.py'>
          Using connect timeout: 5 seconds
          Using 'utf-8' encoding
          Using ssl: False
          Traceback (most recent call last):
            File 
"/home/cassandra/cassandra/bin/../pylib/cqlshlib/cqlshmain.py", line 779, in 
onecmd
              self.handle_statement(st, statementtext)
            File 
"/home/cassandra/cassandra/bin/../pylib/cqlshlib/cqlshmain.py", line 816, in 
handle_statement
              return custom_handler(parsed)
                     ^^^^^^^^^^^^^^^^^^^^^^
            File 
"/home/cassandra/cassandra/bin/../pylib/cqlshlib/cqlshmain.py", line 1486, in 
do_source
              subshell = Shell(self.hostname, self.port, color=self.color,
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
          TypeError: Shell.__init__() missing 1 required positional argument: 
'config_file'
          
          STDERR:
 {noformat}
So, I think that we need to move CONFIG_FILE back as it was before ...


was (Author: smiklosovic):
[~bschoeni]  well, it helped, but there are few more failures (1)

[https://app.circleci.com/pipelines/github/instaclustr/cassandra/3887/workflows/f5e8d089-39ab-4760-a869-f480a948bbfd/jobs/193078/parallel-runs/21?filterBy=FAILED]

Please take a look, thank you very much

However, I think that it wont be so easy, because Python driver is using Shell 
so it wont match the arguments which I fixed 

 
{noformat}
  ✕ j17_cqlsh_dtests_py311                           6m 52s
      cqlsh_tests.test_cqlsh_copy.TestCqlshCopy 
test_round_trip_with_authentication
        AssertionError: Failed to import 10 rows
          STDOUT:
          
          Warning: Using a password on the command line interface can be 
insecure.
          Recommendation: use the credentials file to securely provide the 
password.
          
          Using CQL driver: <module 'cassandra' from 
'/home/cassandra/cassandra/bin/../lib/cassandra-driver-internal-only-3.29.0.zip/cassandra-driver-3.29.0/cassandra/__init__.py'>
          Using connect timeout: 5 seconds
          Using 'utf-8' encoding
          Using ssl: False
          Traceback (most recent call last):
            File 
"/home/cassandra/cassandra/bin/../pylib/cqlshlib/cqlshmain.py", line 779, in 
onecmd
              self.handle_statement(st, statementtext)
            File 
"/home/cassandra/cassandra/bin/../pylib/cqlshlib/cqlshmain.py", line 816, in 
handle_statement
              return custom_handler(parsed)
                     ^^^^^^^^^^^^^^^^^^^^^^
            File 
"/home/cassandra/cassandra/bin/../pylib/cqlshlib/cqlshmain.py", line 1486, in 
do_source
              subshell = Shell(self.hostname, self.port, color=self.color,
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
          TypeError: Shell.__init__() missing 1 required positional argument: 
'config_file'
          
          STDERR:
 {noformat}
So, I think that we need to more CONFIG_FILE back as it was before ...

> Refactor cqlshmain global constants
> -----------------------------------
>
>                 Key: CASSANDRA-19201
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19201
>             Project: Cassandra
>          Issue Type: Task
>          Components: CQL/Interpreter
>            Reporter: Brad Schoening
>            Assignee: Brad Schoening
>            Priority: Low
>             Fix For: 5.x
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Refactor global constants
>  * move globals CASSANDRA_CQL_HTML and cqlruleset
>  * move module level defaults (DEFAULT_) into Shell class
>  * move setup_cqlruleset into cqlshhandling
> Remove unused exceptions 
>  * FunctionNotFound(Exception)
>  * AggregateNotFound(Exception)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to