[ 
https://issues.apache.org/jira/browse/CASSANDRA-19381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815861#comment-17815861
 ] 

Ariel Weisberg edited comment on CASSANDRA-19381 at 2/26/24 4:14 PM:
---------------------------------------------------------------------

[https://github.com/apache/cassandra/pull/3136]

Still need to run the tests


was (Author: aweisberg):
[https://github.com/apache/cassandra/pull/3094]

Currently running tests

> StreamingTombstoneHistogramBuilder.DataHolder does not merge histogram points 
> correctly on overflow
> ---------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-19381
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19381
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/SSTable
>            Reporter: Ariel Weisberg
>            Assignee: Ariel Weisberg
>            Priority: Normal
>             Fix For: 5.0, 5.1
>
>
> The algorithm tries to merge the two nearest points in the histogram and 
> create a new point that is in between the two merged points based on the 
> weight of each point. This can overflow long arithmetic with the code that is 
> currently there  and the work around is pick one of the points and just put 
> it there.
> This can be worked around by changing the midpoint calculation to not 
> overflow.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to