[ https://issues.apache.org/jira/browse/CASSANDRA-19454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823701#comment-17823701 ]
Caleb Rackliffe commented on CASSANDRA-19454: --------------------------------------------- [~arkn98] I think a "bar" of not causing regressions in the existing test suite (which obviously includes tests from CASSANDRA-15241) is acceptable here. Once I have a chance to look at the PR, I can kick off a CI run myself (unless you have a paid CircleCI account and want to go that route). > Revert switch to approximate time in Dispatcher to avoid mixing with > nanoTime() in downstream timeout calculations > ------------------------------------------------------------------------------------------------------------------ > > Key: CASSANDRA-19454 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19454 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Client > Reporter: Caleb Rackliffe > Assignee: Arun Ganesh > Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > CASSANDRA-15241 changed {{Dispatcher}} to use the {{approxTime}} > implementation of {{MonotonicClock}} rather than {{nanoTime()}}, but clock > drift between the two, can potentially cause queries to time out more > quickly. We should be able to revert the {{Dispatcher}} to use {{nanoTime()}} > again and similarly change {{QueriesTable} to {{nanoTime()}} as well for > consistency. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org