[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824019#comment-17824019
]
Stefan Miklosovic commented on CASSANDRA-14572:
-----------------------------------------------
first half of repeated units looks OK
these tests were run
org.apache.cassandra.utils.FBUtilitiesTest
org.apache.cassandra.metrics.TrieMemtableMetricsTest
org.apache.cassandra.metrics.TableMetricsTest
org.apache.cassandra.metrics.LatencyMetricsTest
org.apache.cassandra.metrics.KeyspaceMetricsTest
org.apache.cassandra.metrics.JmxVirtualTableMetricsTest
All tests would be run for more than 1 hour which would timeout on the plan I
have.
I go to schedule another half.
[CASSANDRA-14572|https://github.com/instaclustr/cassandra/tree/CASSANDRA-14572]
{noformat}
java17_pre-commit_tests
java17_separate_tests
java11_pre-commit_tests
java11_separate_tests
✓ j11_build 4m 25s
✓ j11_unit_tests_repeat 41m 53s
{noformat}
[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3956/workflows/705e470d-e5e0-4589-9f87-4498e036bc38]
[java17_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3956/workflows/d8874b26-2bc2-42b8-bc57-32916d9685a9]
[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3956/workflows/0c567ddb-4d6c-41e8-b54f-8ac6bf9457bb]
[java11_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3956/workflows/0ffa8c05-fa84-4322-be6f-126ab6e9acb1]
> Expose all table metrics in virtual table
> -----------------------------------------
>
> Key: CASSANDRA-14572
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14572
> Project: Cassandra
> Issue Type: New Feature
> Components: Legacy/Observability, Observability/Metrics
> Reporter: Chris Lohfink
> Assignee: Maxim Muzafarov
> Priority: Low
> Labels: virtual-tables
> Fix For: 5.x
>
> Attachments: flight_recording_1270017199_13.jfr, keyspayces_group
> responses times.png, keyspayces_group summary.png, select keyspaces_group by
> string prefix.png, select keyspaces_group compare with wo.png, select
> keyspaces_group without value.png, systemv_views.metrics_dropped_message.png,
> thread_pools benchmark.png
>
> Time Spent: 7h
> Remaining Estimate: 0h
>
> While we want a number of virtual tables to display data in a way thats great
> and intuitive like in nodetool. There is also much for being able to expose
> the metrics we have for tooling via CQL instead of JMX. This is more for the
> tooling and adhoc advanced users who know exactly what they are looking for.
> *Schema:*
> Initial idea is to expose data via {{((keyspace, table), metric)}} with a
> column for each metric value. Could also use a Map or UDT instead of the
> column based that can be a bit more specific to each metric type. To that end
> there can be a {{metric_type}} column and then a UDT for each metric type
> filled in, or a single value with more of a Map<Text, Text> style. I am
> purposing the column type though as with {{ALLOW FILTERING}} it does allow
> more extensive query capabilities.
> *Implementations:*
> * Use reflection to grab all the metrics from TableMetrics (see:
> CASSANDRA-7622 impl). This is easiest and least abrasive towards new metric
> implementors... but its reflection and a kinda a bad idea.
> * Add a hook in TableMetrics to register with this virtual table when
> registering
> * Pull from the CassandraMetrics registery (either reporter or iterate
> through metrics query on read of virtual table)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
