absurdfarce commented on PR #1918: URL: https://github.com/apache/cassandra-java-driver/pull/1918#issuecomment-1996093338
Ah, okay, I see your fundamental point @vararo27. I got confused myself by the sequence of CompletionStages at play there but you're correct; what really matters in this case is the CompletableFuture that's passed in as an arg. And in an exception case from DefaultSchemaQueriesFactory.newInstance() that will never get set. I've filed [CASSANDRA-19468](https://issues.apache.org/jira/browse/CASSANDRA-19468) to document this issue. We'll wind up doing something different from what you have in this PR, most likely some changes around the handling of that newInstance() call. But it's definitely an issue we're aware of. Thanks again for the report (and for sticking with me while we work through this)! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
