frankgh commented on code in PR #41:
URL:
https://github.com/apache/cassandra-analytics/pull/41#discussion_r1534250572
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/RingInstance.java:
##########
@@ -130,6 +130,22 @@ private void writeObject(ObjectOutputStream out) throws
IOException
out.writeUTF(ringEntry.fqdn());
out.writeUTF(ringEntry.status());
out.writeUTF(ringEntry.state());
+ if (ringEntry.rack() != null)
Review Comment:
I think this is not sufficient, I pinged you offline for a suggestion
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/common/stats/JobStatsImpl.java:
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.cassandra.spark.common.stats;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Implementation of {@link JobStats} that is used to record stats through the
course of the
+ * Spark job execution and publish them. This implementation logs the stats
when published.
+ */
+public class JobStatsImpl implements JobStats
+{
+ private static final Logger LOGGER =
LoggerFactory.getLogger(JobStatsImpl.class);
+ private final transient Map<String, String> jobStats = new HashMap<>();
+ public void recordJobStats(Map<String, String> stats)
+ {
+ jobStats.putAll(stats);
+ }
+
+ public void publishJobStats()
Review Comment:
can we add override annotations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
