[ https://issues.apache.org/jira/browse/CASSANDRA-19042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830670#comment-17830670 ]
Ekaterina Dimitrova commented on CASSANDRA-19042: ------------------------------------------------- Overall LGTM (though limited knowledge in that part of the codebase, I admit). Some nits left, which can be addressed on commit. The CI run was limited preliminary development testing (the skinny dev workflow Berenguer created). We will need a full pre-commit CI. Also, the patch needs to be propagated to trunk and tested there, too. Do we want to run all tests with paxos_v2 enabled, at least on one of the branches? WDYT? Thanks > Repair fuzz tests fail with paxos_variant: v2 > --------------------------------------------- > > Key: CASSANDRA-19042 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19042 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair, Feature/Lightweight Transactions, > Test/fuzz > Reporter: Branimir Lambov > Assignee: David Capwell > Priority: Normal > Fix For: 5.0-rc, 5.x > > Time Spent: 2.5h > Remaining Estimate: 0h > > Adding {{paxos_variant: v2}} to the test yaml causes all fuzz repair tests to > fail with > {code} > java.lang.NullPointerException: null > at > org.apache.cassandra.gms.EndpointStateSerializer.serializedSize(EndpointState.java:337) > at > org.apache.cassandra.gms.EndpointStateSerializer.serializedSize(EndpointState.java:300) > at > org.apache.cassandra.service.paxos.cleanup.PaxosStartPrepareCleanup$RequestSerializer.serializedSize(PaxosStartPrepareCleanup.java:176) > at > org.apache.cassandra.service.paxos.cleanup.PaxosStartPrepareCleanup$RequestSerializer.serializedSize(PaxosStartPrepareCleanup.java:147) > at > org.apache.cassandra.net.Message$Serializer.payloadSize(Message.java:1067) > at org.apache.cassandra.net.Message.payloadSize(Message.java:1114) > at > org.apache.cassandra.net.Message$Serializer.serializedSize(Message.java:750) > at org.apache.cassandra.net.Message.serializedSize(Message.java:1094) > ... > {code} > This happens for all three options of {{paxos_state_purging}} and both with > and without {{storage_compatibility_mode: NONE}}. > Tests still fail if {{PaxosStartPrepareCleanup}} is changed to use > {{EndpointState.nullableSerializer}}. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org