[
https://issues.apache.org/jira/browse/CASSANDRA-19448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835164#comment-17835164
] Maxwell Guo edited comment on CASSANDRA-19448 at 4/9/24 2:44 PM: ----------------------------------------------------------------- [~brandon.williams] I fixed the failure and remove the precision that you have mentioned . But the CI may be slow because of the limited resource .:( ||Heading 1||Heading 2|| |[4.0|https://github.com/apache/cassandra/pull/3238]| [java8|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/572/workflows/949a3a12-ac70-40ab-b935-185d2a6c51e3] [java11|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/572/workflows/12ebdd83-1a87-4b2c-9806-261ce54c1bb1]| |[4.1|https://github.com/apache/cassandra/pull/3237]| [java8|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/573/workflows/8983cd7b-8a35-4b06-81b4-bef66aa02ab7] [java11|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/573/workflows/eeffd27e-227c-4720-865f-e0bc7c563496]| |[5.0|https://github.com/apache/cassandra/pull/3236]| [java11|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/574/workflows/08679195-4afd-4ff2-95e3-ea7800e2145a] [java17|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/574/workflows/c889a4f2-76d9-4dc5-97b2-ce51f6c60405] | |[trunk|https://github.com/apache/cassandra/pull/3215]| [java11|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/575/workflows/276a267b-315d-41d2-a216-3ba2912fdb9f] [java17|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/575/workflows/9fab5111-8209-4889-b839-006d02c4f3ce] | was (Author: maxwellguo): [~brandon.williams] I fixed the failure and remove the precision that you have mentioned . But the CI may be slow because of the limited resource .:( ||Heading 1||Heading 2|| |[4.0|https://github.com/apache/cassandra/pull/3238]| [java8|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/571/workflows/bb88be9e-4745-4ed0-b7d1-a101cd76c913] [java11|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/571/workflows/dfb90672-e5a8-44bf-9d14-e3d5e5bb3934]| |[4.1|https://github.com/apache/cassandra/pull/3237]| [java8|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/570/workflows/c9d44874-9ddd-4618-b464-136c8c94e3f7] [java11|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/570/workflows/dc8e1c13-84c8-4032-9a03-34f7220a7379]| |[5.0|https://github.com/apache/cassandra/pull/3236]| [java11|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/569/workflows/2221edd7-60bc-4c5d-bccc-a6bea1abc7ba] [java17|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/569/workflows/6b94b590-bdbf-4250-a7f7-f6b78c38292d] | |[trunk|https://github.com/apache/cassandra/pull/3215]| [java11|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/568/workflows/12d9bbbd-fb19-477d-92e0-5534e0da652e] [java17|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/568/workflows/5aad317f-cf3b-411a-8c68-8910cb52d005] | > CommitlogArchiver only has granularity to seconds for restore_point_in_time > --------------------------------------------------------------------------- > > Key: CASSANDRA-19448 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19448 > Project: Cassandra > Issue Type: Bug > Components: Local/Commit Log > Reporter: Jeremy Hanna > Assignee: Maxwell Guo > Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Commitlog archiver allows users to backup commitlog files for the purpose of > doing point in time restores. The [configuration > file|https://github.com/apache/cassandra/blob/trunk/conf/commitlog_archiving.properties] > gives an example of down to the seconds granularity but then asks what > whether the timestamps are microseconds or milliseconds - defaulting to > microseconds. Because the [CommitLogArchiver uses a second based date > format|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogArchiver.java#L52], > if a user specifies to restore at something at a lower granularity like > milliseconds or microseconds, that means that the it will truncate everything > after the second and restore to that second. So say you specify a > restore_point_in_time like this: > restore_point_in_time=2024:01:18 17:01:01.623392 > it will silently truncate everything after the 01 seconds. So effectively to > the user, it is missing updates between 01 and 01.623392. > This appears to be a bug in the intent. We should allow users to specify > down to the millisecond or even microsecond level. If we allow them to > specify down to microseconds for the restore point in time, then it may > internally need to change from a long. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
