[
https://issues.apache.org/jira/browse/CASSANDRA-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837179#comment-17837179
]
Sam Tunnicliffe edited comment on CASSANDRA-12937 at 4/15/24 11:11 AM:
-----------------------------------------------------------------------
The problem with that is that the defaults may be different on every instance,
so what exactly should be stored in the TCM log? Ideally we should store the
value that is actually resolved during initial execution on each node so that
it can be re-used if/when the transformation is reapplied. That should probably
be in a parallel local datastructure though, not in the node's local log table
as we don't want to ship those local defaults to peers when providing log
catchup (because they should use their own defaults).
was (Author: beobal):
The problem with that is that the defaults may be different on every instance,
so what exactly should be stored in the TCM log? Ideally we should store the
value that is actually resolved during initial execution on each node to be
persisted locally so that it can be re-used if/when the transformation is
reapplied. That should probably be in a parallel local datastructure though,
not in the node's local log table as we don't want to ship those local defaults
to peers when providing log catchup (because they should use their own
defaults).
> Default setting (yaml) for SSTable compression
> ----------------------------------------------
>
> Key: CASSANDRA-12937
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12937
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
> Reporter: Michael Semb Wever
> Assignee: Stefan Miklosovic
> Priority: Low
> Labels: AdventCalendar2021
> Fix For: 5.x
>
> Time Spent: 8h
> Remaining Estimate: 0h
>
> In many situations the choice of compression for sstables is more relevant to
> the disks attached than to the schema and data.
> This issue is to add to cassandra.yaml a default value for sstable
> compression that new tables will inherit (instead of the defaults found in
> {{CompressionParams.DEFAULT}}.
> Examples where this can be relevant are filesystems that do on-the-fly
> compression (btrfs, zfs) or specific disk configurations or even specific C*
> versions (see CASSANDRA-10995 ).
> +Additional information for newcomers+
> Some new fields need to be added to {{cassandra.yaml}} to allow specifying
> the field required for defining the default compression parameters. In
> {{DatabaseDescriptor}} a new {{CompressionParams}} field should be added for
> the default compression. This field should be initialized in
> {{DatabaseDescriptor.applySimpleConfig()}}. At the different places where
> {{CompressionParams.DEFAULT}} was used the code should call
> {{DatabaseDescriptor#getDefaultCompressionParams}} that should return some
> copy of configured {{CompressionParams}}.
> Some unit test using {{OverrideConfigurationLoader}} should be used to test
> that the table schema use the new default when a new table is created (see
> CreateTest for some example).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
