absurdfarce commented on code in PR #1896:
URL: 
https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1585228162


##########
core/src/main/resources/reference.conf:
##########
@@ -574,6 +574,11 @@ datastax-java-driver {
       # Modifiable at runtime: no
       # Overridable in a profile: yes
       allow-for-local-consistency-levels = false
+      # Ordered preference list of remote dc's (in order) optionally supplied 
for automatic failover. While building a query plan, the driver uses the DC's 
supplied in order together with max-nodes-per-remote-dc

Review Comment:
   Another nit: might be worth mentioning that users aren't required to specify 
all DCs when listing preferences via this config.



##########
core/src/main/resources/reference.conf:
##########
@@ -574,6 +574,11 @@ datastax-java-driver {
       # Modifiable at runtime: no
       # Overridable in a profile: yes
       allow-for-local-consistency-levels = false
+      # Ordered preference list of remote dc's (in order) optionally supplied 
for automatic failover. While building a query plan, the driver uses the DC's 
supplied in order together with max-nodes-per-remote-dc

Review Comment:
   Nit: should be a space between this and allow-for-local-consistency-levels 
in order to make it clear we're talking about two distinct configs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to