[
https://issues.apache.org/jira/browse/CASSANDRA-19632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845733#comment-17845733
]
Stefan Miklosovic commented on CASSANDRA-19632:
-----------------------------------------------
Well ... I created this ticket to be of type "improvement" and fix versions are
5.0.x and 5.x. I think that says it all.
I also wrote: _We should fix this at least in trunk and 5.0 (not critical
though)_
Yeah, 5.0 is just nice to have, not critical ...
We also do not know how to quantify the improvement. Can we tell for sure what
other (significant) performance improvements are out there? I think we were
rather "lucky" to hit something like CASSANDRA-19429 but that does not mean
that such improvements would be indeed found at other places too.
> wrap tracing logs in isTraceEnabled across the codebase
> -------------------------------------------------------
>
> Key: CASSANDRA-19632
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19632
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stefan Miklosovic
> Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> Our usage of logger.isTraceEnabled across the codebase is inconsistent. This
> would also fix issues similar in e.g. CASSANDRA-19429 as [~rustyrazorblade]
> suggested.
> We should fix this at least in trunk and 5.0 (not critical though) and
> probably come up with a checkstyle rule to prevent not calling isTraceEnabled
> while logging with TRACE level.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
