[ 
https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846093#comment-17846093
 ] 

Brandon Williams edited comment on CASSANDRA-18106 at 5/13/24 10:04 PM:
------------------------------------------------------------------------

Ah, that's right. I think this was a relevant bit:

 

bq. b) we run the python dtest upgrade tests twice and each run ignores 
(filters out) upgrade paths that are not valid for the current JAVA_HOME jdk.

 

So we obviated the need to switch JDKs during a run by doing more runs with 
adjacent versions that share the same JDK.


was (Author: brandon.williams):
Ah, that's right. I think this was a relevant bit:

 

> b) we run the python dtest upgrade tests twice and each run ignores (filters 
> out) upgrade paths that are not valid for the current JAVA_HOME jdk.

 

So we obviated the need to switch JDKs during a run by doing more runs with 
adjacent versions that share the same JDK.

> Update CCM for JDK17 and revise current JDK detection strategy
> --------------------------------------------------------------
>
>                 Key: CASSANDRA-18106
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18106
>             Project: Cassandra
>          Issue Type: Task
>          Components: CI
>            Reporter: Ekaterina Dimitrova
>            Assignee: Brandon Williams
>            Priority: Normal
>             Fix For: 5.0-alpha1, 5.0
>
>         Attachments: Screenshot 2023-03-03 at 09.24.50.png
>
>
> As part of CASSANDRA-16895 initial POC an initial version of CCM patch was 
> created. This needs to be revisited and reviewed
> Recently we closed CASSANDRA-18039 which brought questions, probably we need 
> to revise how we detect JDK versions in CCM and whether it is correct. To the 
> best of my knowledge there are certain tests in the repo around that and they 
> pass so my guess is we need to revise just the strategy and maybe document it 
> explicitly or consider if we want any changes to be applied. Also, we need to 
> be careful with breaking changes. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to