[
https://issues.apache.org/jira/browse/CASSANDRA-19556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848709#comment-17848709
]
Michael Semb Wever edited comment on CASSANDRA-19556 at 5/22/24 8:00 PM:
-------------------------------------------------------------------------
bq. it is removing alter_table_enabled guardrail.
We can deprecate alter_table_enabled in 5.0.1
If I'm reading all comments correctly, it seems the right approach is this
ticket waits til 5.0.0 is released, and then introduces the system property in
4.0, 4.1, 5.0 branches, deprecates alter_table_enabled in cassandra-5.0, and
applies the current patch to trunk.
was (Author: michaelsembwever):
bq. it is removing alter_table_enabled guardrail.
We can deprecate alter_table_enabled in 5.0.1
If I'm reading all comments correctly, it seems the right approach is this
ticket waits til 5.0.0 is released, and then introduces the system property in
<trunk branches, deprecates alter_table_enabled in cassandra-5.0, and applies
the current patch to trunk.
> Add guardrail to block DDL/DCL queries and replace alter_table_enabled
> guardrail
> --------------------------------------------------------------------------------
>
> Key: CASSANDRA-19556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19556
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
> Reporter: Yuqi Yan
> Assignee: Yuqi Yan
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Sometimes we want to block DDL/DCL queries to stop new schemas being created
> or roles created. (e.g. when doing live-upgrade)
> For DDL guardrail current implementation won't block the query if it's no-op
> (e.g. CREATE TABLE...IF NOT EXISTS, but table already exists, etc. The
> guardrail check is added in apply() right after all the existence check)
> I don't have preference on either block every DDL query or check whether if
> it's no-op here. Just we have some users always run CREATE..IF NOT EXISTS..
> at startup, which is no-op but will be blocked by this guardrail and failed
> to start.
>
> 4.1 PR: [https://github.com/apache/cassandra/pull/3248]
> trunk PR: [https://github.com/apache/cassandra/pull/3275]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
