[ https://issues.apache.org/jira/browse/CASSANDRA-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849221#comment-17849221 ]
Stefan Miklosovic edited comment on CASSANDRA-19450 at 5/24/24 8:51 AM: ------------------------------------------------------------------------ I think this just looks fine. Going to ship it. [CASSANDRA-19450|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19450] {noformat} java17_pre-commit_tests ✓ j17_build 4m 14s ✓ j17_cqlsh_dtests_py311 6m 57s ✓ j17_cqlsh_dtests_py311_vnode 7m 22s ✓ j17_cqlsh_dtests_py38 6m 55s ✓ j17_cqlsh_dtests_py38_vnode 7m 17s ✓ j17_cqlshlib_cython_tests 7m 16s ✓ j17_cqlshlib_tests 6m 23s ✓ j17_dtests 36m 35s ✓ j17_dtests_vnode 35m 1s ✓ j17_unit_tests 14m 20s ✓ j17_utests_oa 13m 2s ✕ j17_dtests_latest 35m 19s streaming_test.TestStreaming test_zerocopy_streaming_no_replication ✕ j17_jvm_dtests 24m 34s org.apache.cassandra.fuzz.harry.integration.model.InJVMTokenAwareExecutorTest testRepair TIMEOUTED ✕ j17_jvm_dtests_latest_vnode 24m 15s org.apache.cassandra.distributed.test.jmx.JMXFeatureTest testOneNetworkInterfaceProvisioning ✕ j17_utests_latest 15m 50s org.apache.cassandra.tcm.DiscoverySimulationTest discoveryTest java17_separate_tests java11_pre-commit_tests java11_separate_tests {noformat} [java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4351/workflows/5f522c11-aae5-4915-8102-f79807d661d6] [java17_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4351/workflows/87429218-e1e2-4589-b879-09f9e80ef3b6] [java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4351/workflows/222ad871-683e-4a14-919d-9e3e92def96c] [java11_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4351/workflows/3cd71329-9b0f-4f48-ae2b-33fd057520c9] streaming_test.py::TestStreaming::test_zerocopy_streaming_no_replication was verified to work locally was (Author: smiklosovic): I think this just looks fine. Going to ship it. [CASSANDRA-19450|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19450] {noformat} java17_pre-commit_tests ✓ j17_build 4m 14s ✓ j17_cqlsh_dtests_py311 6m 57s ✓ j17_cqlsh_dtests_py311_vnode 7m 22s ✓ j17_cqlsh_dtests_py38 6m 55s ✓ j17_cqlsh_dtests_py38_vnode 7m 17s ✓ j17_cqlshlib_cython_tests 7m 16s ✓ j17_cqlshlib_tests 6m 23s ✓ j17_dtests 36m 35s ✓ j17_dtests_vnode 35m 1s ✓ j17_unit_tests 14m 20s ✓ j17_utests_oa 13m 2s ✕ j17_dtests_latest 35m 19s streaming_test.TestStreaming test_zerocopy_streaming_no_replication ✕ j17_jvm_dtests 24m 34s org.apache.cassandra.fuzz.harry.integration.model.InJVMTokenAwareExecutorTest testRepair TIMEOUTED ✕ j17_jvm_dtests_latest_vnode 24m 15s org.apache.cassandra.distributed.test.jmx.JMXFeatureTest testOneNetworkInterfaceProvisioning ✕ j17_utests_latest 15m 50s org.apache.cassandra.tcm.DiscoverySimulationTest discoveryTest java17_separate_tests java11_pre-commit_tests java11_separate_tests {noformat} [java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4351/workflows/5f522c11-aae5-4915-8102-f79807d661d6] [java17_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4351/workflows/87429218-e1e2-4589-b879-09f9e80ef3b6] [java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4351/workflows/222ad871-683e-4a14-919d-9e3e92def96c] [java11_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4351/workflows/3cd71329-9b0f-4f48-ae2b-33fd057520c9] > Hygiene updates for warnings and pytests > ---------------------------------------- > > Key: CASSANDRA-19450 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19450 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter > Reporter: Brad Schoening > Assignee: Brad Schoening > Priority: Low > Fix For: 5.x > > > > * -Update 'Warning' message to write to stderr- > * -Replace TimeoutError Exception with builtin (since Python 3.3)- > * -Remove re.pattern_type (removed since Python 3.7)- > * Fix mutable arg [] in test/run_cqlsh.py read_until() > * Remove redirect of stderr to stdout in pytest fixture with tty=false; > Deprecation warnings can otherwise fail unit tests when stdout & stderr > output is combined. > * Fix several pycodestyle issues -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org