lukasz-antoniak commented on code in PR #1934:
URL:
https://github.com/apache/cassandra-java-driver/pull/1934#discussion_r1613817782
##########
test-infra/src/main/java/com/datastax/oss/driver/api/testinfra/ccm/BaseCcmRule.java:
##########
@@ -38,7 +38,7 @@ public abstract class BaseCcmRule extends
CassandraResourceRule {
new Thread(
() -> {
try {
- ccmBridge.remove();
+ ccmBridge.close();
Review Comment:
I have made `CcmBridge#close()` dependent on `created` flag. Now we execute
`ccm remove` only once if the cluster was previously created and not removed
after that. If you run FT and log CCM command executions, you would see that we
clean-up cluster twice (execute `ccm remove`):
1. In `BaseCcmRule#after()`.
2. As part of `AutoCloseable` and resource `close()` method.
Of course running `ccm remove` twice does not do any harm. IMO this fix is
most about taste, so I can revert this back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
