[
https://issues.apache.org/jira/browse/CASSANDRA-17667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850127#comment-17850127
]
Brad Schoening edited comment on CASSANDRA-17667 at 5/28/24 6:40 PM:
---------------------------------------------------------------------
[~brandon.williams] [~smiklosovic] [~bereng] CQLSH 4.1.x and 5.x all use the
pytest framework and test_cql_parsing.py runs successfully. But 4.0.x uses
nosetests which I was never able to run.
IDK if 4.0.x is worth the effort, but the 4.1 PR should cherry-pick easily if
someone can run the nose tests including the updated unit tests added here for
unclosed productions. Or consider it safest to just fix it where pytest is
running.
PR's for 4.1.x, 5.0.x, 5.1.x are linked here.
was (Author: bschoeni):
[~brandon.williams] [~smiklosovic] [~bereng] CQLSH 4.1.x and 5.x all use the
pytest framework and test_cql_parsing.py runs successfully. But 4.0.x uses
nosetests which I was never able to run.
IDK if 4.0.x is worth the effort, but the 4.1 PR should cherry-pick easily if
someone can run the nose tests including the updated unit tests added here for
unclosed productions.
PR's for 4.1.x, 5.0.x, 5.1.x are linked here.
> Text value containing "/*" interpreted as multiline comment in cqlsh
> --------------------------------------------------------------------
>
> Key: CASSANDRA-17667
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17667
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Interpreter
> Reporter: ANOOP THOMAS
> Assignee: Brad Schoening
> Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
>
> I use CQLSH command line utility to load some DDLs. The version of utility I
> use is this:
> {noformat}
> [cqlsh 6.0.0 | Cassandra 4.0.0.47 | CQL spec 3.4.5 | Native protocol
> v5]{noformat}
> Command that loads DDL.cql:
> {noformat}
> cqlsh -u username -p password cassandra.example.com 65503 --ssl -f DDL.cql
> {noformat}
> I have a line in CQL script that breaks the syntax.
> {noformat}
> INSERT into tablename (key,columnname1,columnname2) VALUES
> ('keyName','value1','/value2/*/value3');{noformat}
> {{/*}} here is interpreted as start of multi-line comment. It used to work on
> older versions of cqlsh. The error I see looks like this:
> {noformat}
> SyntaxException: line 4:2 mismatched input 'Update' expecting ')'
> (...,'value1','/value2INSERT into tablename(INSERT into tablename
> (key,columnname1,columnname2)) VALUES ('[Update]-...) SyntaxException: line
> 1:0 no viable alternative at input '(' ([(]...)
> {noformat}
> Same behavior while running in interactive mode too. {{/*}} inside a CQL
> statement should not be interpreted as start of multi-line comment.
> With schema:
> {code:java}
> CREATE TABLE tablename ( key text primary key, columnname1 text, columnname2
> text);{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
