[ https://issues.apache.org/jira/browse/CASSANDRA-19604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851802#comment-17851802 ]
Ekaterina Dimitrova commented on CASSANDRA-19604: ------------------------------------------------- This seems almost ready. Left a few comments on the PR. I will do a final full pass once the latest test failures and agreement around SAI filtering are addressed. Thank you. [~xvade], I believe [~blerer] is already looking into those things so nothing is expected from you here! Thank you so much for your great work! [~blerer] , I suggest we pull the NOT BETWEEN scope to a separate ticket. > Add support for BETWEEN operator > -------------------------------- > > Key: CASSANDRA-19604 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19604 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter > Reporter: Benjamin Lerer > Assignee: Simon Chess > Priority: Normal > Fix For: 5.x > > Time Spent: 3h > Remaining Estimate: 0h > > CQL support the {{>=}} and {{<=}} but does not support yet the {{BETWEEN}} > operator. After CASSANDRA-19341 adding new operators should be much simpler > and safer than it use to be. > For the scope of this ticket {{BETWEEN}} support should be added for > {{WHERE}} clauses of {{SELECT}} and {{DELETE}} queries (for single column and > multi-column restrictions). NOT BETWEEN should be added and should be > supported everywhere BETWEEN is. > +Additional information for newcomers:+ > Parts that will need to be modified: > * {{Lexer.g}} and {{Parser.g}} to add support for the new keyword and syntax > * The {{Operator.class}} to add the new {{BETWEEN}} operator > * Unit tests in {{SelectSingleColumnRelationTest}} and > {{SelectMultiColumnRelationTest}} classes for the different types of columns > (partition key, clustering, static and regular). > * CQLSH auto completion in {{cql3handling.py}} and test for it in > {{test_cqlsh_completion.py}} > * Update the documentation > Of course this is just an overview and some other parts might have to be > changed as well. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org