[ https://issues.apache.org/jira/browse/CASSANDRA-19604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852217#comment-17852217 ]
Ekaterina Dimitrova edited comment on CASSANDRA-19604 at 6/4/24 11:38 PM: -------------------------------------------------------------------------- Making final pass of [GitHub Pull Request #3345|https://github.com/apache/cassandra/pull/3345] , CI run: [https://app.circleci.com/pipelines/github/blerer/cassandra/416/workflows/cc2cebdf-452f-46d8-aec7-ea342c686f96] I made the JDK17 build locally and it passes. We found all the test failures in previous runs or tickets. New tickets are needed for: * test_rename_column_atomicity * bounceTest * org.apache.cassandra.fuzz.sai.MultiNodeSAITest - timing out on too log without output * test_tracing_default_impl Known failures: test_stop_failure_policy - CASSANDRA-19100 org.apache.cassandra.simulator.test.HarrySimulatorTest - CASSANDRA-19279 updateTokensTest-oa_jdk11 - CASSANDRA-19089 testMessageDeliveryOnReconnect-oa_jdk11 - CASSANDRA-16677 org.apache.cassandra.db.ColumnsTest-oa_jdk11 - seems environmental, and it does not fail locally. was (Author: e.dimitrova): Making final pass of [GitHub Pull Request #3345|https://github.com/apache/cassandra/pull/3345] , CI run: [https://app.circleci.com/pipelines/github/blerer/cassandra/416/workflows/cc2cebdf-452f-46d8-aec7-ea342c686f96] I make the JDK17 build locally and it passes. We found all the test failures in previous runs or tickets. New tickets are needed for: * test_rename_column_atomicity * bounceTest * org.apache.cassandra.fuzz.sai.MultiNodeSAITest - timing out on too log without output * test_tracing_default_impl Known failures: test_stop_failure_policy - CASSANDRA-19100 org.apache.cassandra.simulator.test.HarrySimulatorTest - CASSANDRA-19279 updateTokensTest-oa_jdk11 - CASSANDRA-19089 testMessageDeliveryOnReconnect-oa_jdk11 - CASSANDRA-16677 org.apache.cassandra.db.ColumnsTest-oa_jdk11 - seems environmental, and it does not fail locally. > Add support for BETWEEN operator > -------------------------------- > > Key: CASSANDRA-19604 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19604 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter > Reporter: Benjamin Lerer > Assignee: Simon Chess > Priority: Normal > Fix For: 5.x > > Time Spent: 3h 10m > Remaining Estimate: 0h > > CQL support the {{>=}} and {{<=}} but does not support yet the {{BETWEEN}} > operator. After CASSANDRA-19341 adding new operators should be much simpler > and safer than it use to be. > For the scope of this ticket {{BETWEEN}} support should be added for > {{WHERE}} clauses of {{SELECT}} and {{DELETE}} queries (for single column and > multi-column restrictions). NOT BETWEEN should be added and should be > supported everywhere BETWEEN is. > +Additional information for newcomers:+ > Parts that will need to be modified: > * {{Lexer.g}} and {{Parser.g}} to add support for the new keyword and syntax > * The {{Operator.class}} to add the new {{BETWEEN}} operator > * Unit tests in {{SelectSingleColumnRelationTest}} and > {{SelectMultiColumnRelationTest}} classes for the different types of columns > (partition key, clustering, static and regular). > * CQLSH auto completion in {{cql3handling.py}} and test for it in > {{test_cqlsh_completion.py}} > * Update the documentation > Of course this is just an overview and some other parts might have to be > changed as well. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org