[ https://issues.apache.org/jira/browse/CASSANDRA-19288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855153#comment-17855153 ]
Blake Eggleston commented on CASSANDRA-19288: --------------------------------------------- [~benedict] [~dcapwell] would either of you be able to review? The read process does the right thing if the command is preapplied and aborts, however it doesn’t cancel async reads. This patch just moves the read timestamp validation into the coordinator. So if we read future state and it somehow escapes the read process the same error will be thrown. Assuming there are no objections to this approach, I’ll add a note to CASSANDRA-19316 to cancel reads. > Accord: Asynchronous reads may be unsafe > ---------------------------------------- > > Key: CASSANDRA-19288 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19288 > Project: Cassandra > Issue Type: Improvement > Components: Accord > Reporter: Benedict Elliott Smith > Assignee: Blake Eggleston > Priority: Normal > Attachments: ci_summary.html > > > In principle we should invalidate asynchronous reads before they complete if > the data they read may be invalid, but this anyway causes faults when we > permit them to occur in accord-core. We can and perhaps should simply ensure > the reads are issued against an sstable/memtable snapshot taken by the > command store, as this is lower cost and more robust. Otherwise we should > investigate what issue asynchronous reads cause. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org