[ https://issues.apache.org/jira/browse/CASSANDRA-19556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17856432#comment-17856432 ]
Stefan Miklosovic commented on CASSANDRA-19556: ----------------------------------------------- To plan this correctly and ahead of time, the above what Mick suggested will consist in fact in three tickets / individual commits: 1) one ticket and merge up from 4.0 to 5.0 for system property to prevent schema modifications 2) one ticket for the deprecation of alter_table_enabled in 5.0.1 only, no need to merge that to trunk when we go to remove it there 3) removal of alter_table_enabled in trunk / application of this ticket. There are no tickets for 1) and 2) yet. > Add guardrail to block DDL/DCL queries and replace alter_table_enabled > guardrail > -------------------------------------------------------------------------------- > > Key: CASSANDRA-19556 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19556 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Guardrails > Reporter: Yuqi Yan > Assignee: Yuqi Yan > Priority: Normal > Fix For: 5.x > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Sometimes we want to block DDL/DCL queries to stop new schemas being created > or roles created. (e.g. when doing live-upgrade) > For DDL guardrail current implementation won't block the query if it's no-op > (e.g. CREATE TABLE...IF NOT EXISTS, but table already exists, etc. The > guardrail check is added in apply() right after all the existence check) > I don't have preference on either block every DDL query or check whether if > it's no-op here. Just we have some users always run CREATE..IF NOT EXISTS.. > at startup, which is no-op but will be blocked by this guardrail and failed > to start. > > 4.1 PR: [https://github.com/apache/cassandra/pull/3248] > trunk PR: [https://github.com/apache/cassandra/pull/3275] > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org