[
https://issues.apache.org/jira/browse/CASSANDRA-19675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-19675:
----------------------------------------
Fix Version/s: 5.0
5.1
(was: 5.x)
(was: 5.0.x)
Source Control Link:
https://github.com/apache/cassandra/commit/ba5ab993c7a279b014f439a5d06683d3b568d4ff
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Avoid streams in the common case for UpdateTransaction creation
> ---------------------------------------------------------------
>
> Key: CASSANDRA-19675
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19675
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/SAI
> Reporter: Caleb Rackliffe
> Assignee: Caleb Rackliffe
> Priority: Normal
> Fix For: 5.0, 5.1
>
> Attachments: ci_summary-1.html, ci_summary.html,
> new_update_txn_streams.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Some recent Accord profiling highlighted some easily addressable inefficiency
> in the way we create new {{UpdateTransaction}} objects in
> {{SecondaryIndexManager}} that have existed since the introduction of index
> groups for SAI. We should be able to clean this up by avoiding stream
> creation or even iteration over the groups when there is a single index
> group, which is going to be the most common case with SAI anyway. If we do
> have to iterate, there should also be no reason to copy the collection of
> index groups via {{listIndexGroups()}}, although that copying can remain in
> the method itself for external callers.
> !new_update_txn_streams.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
