[
https://issues.apache.org/jira/browse/CASSANDRA-19704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17861320#comment-17861320
]
Marcus Eriksson commented on CASSANDRA-19704:
---------------------------------------------
I don't think we can check {{<= 1}} - we'd fail the assertion
[here|https://github.com/apache/cassandra/blob/be70c892b6c474d1d32eaba1864f1bdc3444f52b/src/java/org/apache/cassandra/db/compaction/CompactionTask.java#L390].
In {{LeveledCompactionTask}} during L0 -> L1 compactions we only remove
sstables from L0 so we could still have non-expired L1 sstables in the
transaction. We could probably cancel the L1 sstables from the transaction and
compact only the expired ones though.
+1 on the {{level == 0}} patch if we want the bug fixed and we can revisit and
improve later.
> UnsupportedOperationException is thrown when no space for LCS
> -------------------------------------------------------------
>
> Key: CASSANDRA-19704
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19704
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction/LCS
> Reporter: Zhao Yang
> Assignee: Caleb Rackliffe
> Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Attachments: ci_summary-1.html, ci_summary-2.html, ci_summary-3.html,
> ci_summary.html
>
>
> In {{CompactionTask#buildCompactionCandidatesForAvailableDiskSpace}} with
> LCS, if node has limited disk space and can't remove any sstable from L0 or
> L1 in {{{}LeveledCompactionTask#reduceScopeForLimitedSpace{}}},
> {{LeveledCompactionTask#partialCompactionsAcceptable}} will throw
> {{UnsupportedOperationException}}.
> We should handle {{LeveledCompactionTask#partialCompactionsAcceptable}} more
> gracefully with {{return level <= 1}} or simply {{true}} since
> {{reduceScopeForLimitedSpace}} only removes sstable from L0 or L1.
> Related https://issues.apache.org/jira/browse/CASSANDRA-17272
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
