absurdfarce commented on code in PR #1939:
URL:
https://github.com/apache/cassandra-java-driver/pull/1939#discussion_r1662902550
##########
integration-tests/src/test/java/com/datastax/oss/driver/mapper/DeleteIT.java:
##########
@@ -56,8 +56,8 @@
// Do not run LWT tests in parallel because they may interfere. Tests operate
on the same row.
@BackendRequirement(
type = BackendType.CASSANDRA,
- minInclusive = "3.0",
- description = ">= in WHERE clause not supported in legacy versions")
+ minInclusive = "3.4",
+ description = ">= in WHERE clause, and SASI indexes are not supported in
legacy versions")
Review Comment:
I'd say make it even easier: just overload createStatements() with
requiresSasiIndex as false in the default case:
```java
protected static List<String> createStatements(BaseCcmRule ccmRule) {
return createStatements(ccmRule, false);
}
```
Unless I'm missing something that means you only need to modify
SelectCustomWhereClauseIT since it's the only one that actually passes in
"true" for the SASI create argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
