[
https://issues.apache.org/jira/browse/CASSANDRA-19747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17862875#comment-17862875
]
Stefan Miklosovic commented on CASSANDRA-19747:
-----------------------------------------------
[CASSANDRA-19747-4.0|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19747-4.0]
{noformat}
java11_pre-commit_tests
✓ j11_build 1m 29s
✓ j11_cqlsh-dtests-py2-no-vnodes 5m 34s
✓ j11_cqlsh-dtests-py2-with-vnodes 5m 33s
✓ j11_cqlsh_dtests_py3 5m 24s
✓ j11_cqlsh_dtests_py311 5m 41s
✓ j11_cqlsh_dtests_py311_vnode 5m 35s
✓ j11_cqlsh_dtests_py38 5m 50s
✓ j11_cqlsh_dtests_py38_vnode 5m 50s
✓ j11_cqlsh_dtests_py3_vnode 5m 51s
✓ j11_cqlshlib_tests 7m 35s
✓ j11_dtests 33m 46s
✓ j11_dtests_vnode 35m 5s
✓ j11_jvm_dtests 9m 26s
✓ j11_unit_tests_repeat 3m 15s
✕ j11_unit_tests 8m 9s
org.apache.cassandra.cql3.MemtableSizeTest testTruncationReleasesLogSpace
{noformat}
[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4463/workflows/e22e6a6b-cb68-4995-bd0f-9239997f0931]
> Invalid schema.cql created by snapshot after dropping more than one field
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-19747
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19747
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Snapshots
> Reporter: Frank vissing
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> After dropping at least 2 fields the schema.cql produced by _nodetool
> snapshot_ is invalid (it is missing a comma)
> {code:sql}
> CREATE TABLE IF NOT EXISTS test.testtable (
> field1 text PRIMARY KEY,
> field2 text
> field3 text
> ) WITH ID ...{code}
> expected outcome
> {code:sql}
> CREATE TABLE IF NOT EXISTS test.testtable (
> field1 text PRIMARY KEY,
> field2 text,
> field3 text
> ) WITH ID ...{code}
> reproducing the isue is simple by running the following commands
> {code:sh}
> docker run -d --name cassandra cassandra:4.1.5
> echo "Wait for the container to start"
> until docker exec -ti cassandra nodetool status | grep UN;do sleep
> 1;done;sleep 10
> echo "Create keyspace and table for test"
> docker exec -ti cassandra cqlsh -e "CREATE KEYSPACE IF NOT EXISTS test WITH
> replication = {'class': 'SimpleStrategy', 'replication_factor': '1'}; CREATE
> TABLE IF NOT EXISTS test.testtable (field1 text PRIMARY KEY,field2
> text,field3 text);"
> echo "Drop 2 fields"
> docker exec -ti cassandra cqlsh -e "ALTER TABLE test.testtable DROP (field2,
> field3);"
> echo "Create snapshot and view schema.cql"
> docker exec -ti cassandra /opt/cassandra/bin/nodetool snapshot -t my_snapshot
> docker exec -ti cassandra find /var/lib/cassandra/data -name schema.cql
> -exec cat {} + {code}
> the full output of the sql generated by the reproduce is below
> {code:sql}
> CREATE TABLE IF NOT EXISTS test.testtable (
> field1 text PRIMARY KEY,
> field2 text
> field3 text
> ) WITH ID = 0e9aa540-391f-11ef-945e-0be1221ff441
> AND additional_write_policy = '99p'
> AND bloom_filter_fp_chance = 0.01
> AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'}
> AND cdc = false
> AND comment = ''
> AND compaction = {'class':
> 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy',
> 'max_threshold': '32', 'min_threshold': '4'}
> AND compression = {'chunk_length_in_kb': '16', 'class':
> 'org.apache.cassandra.io.compress.LZ4Compressor'}
> AND memtable = 'default'
> AND crc_check_chance = 1.0
> AND default_time_to_live = 0
> AND extensions = {}
> AND gc_grace_seconds = 864000
> AND max_index_interval = 2048
> AND memtable_flush_period_in_ms = 0
> AND min_index_interval = 128
> AND read_repair = 'BLOCKING'
> AND speculative_retry = '99p';
> ALTER TABLE test.testtable DROP field2 USING TIMESTAMP 1719999102807000;
> ALTER TABLE test.testtable DROP field3 USING TIMESTAMP 1719999102807001;
> {code}
> Found this bug while trying to restore the schema from a backup created by
> copying a snapshot from a running node.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
