[
https://issues.apache.org/jira/browse/CASSANDRA-18111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868695#comment-17868695
]
Stefan Miklosovic commented on CASSANDRA-18111:
-----------------------------------------------
[CASSANDRA-18111|https://github.com/instaclustr/cassandra/tree/CASSANDRA-18111]
{noformat}
java17_pre-commit_tests
✓ j17_build 4m 23s
✓ j17_cqlsh_dtests_py311 6m 53s
✓ j17_cqlsh_dtests_py311_vnode 7m 19s
✓ j17_cqlsh_dtests_py38 7m 7s
✓ j17_cqlsh_dtests_py38_vnode 7m 8s
✓ j17_cqlshlib_cython_tests 7m 34s
✓ j17_cqlshlib_tests 6m 28s
✓ j17_dtests 35m 13s
✓ j17_unit_tests 12m 48s
✓ j17_utests_latest 12m 55s
✓ j17_utests_oa 14m 8s
✕ j17_dtests_latest 36m 17s
bootstrap_test.TestBootstrap
test_consistent_range_movement_false_with_rf1_should_succeed
✕ j17_dtests_vnode 48m 41s
bootstrap_test.TestBootstrap test_killed_wiped_node_cannot_join
✕ j17_jvm_dtests 25m 20s
✕ j17_jvm_dtests_latest_vnode 26m 17s
org.apache.cassandra.distributed.test.tcm.CMSPlacementAfterMoveTest
testMoveToCMS
{noformat}
[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4535/workflows/4d3b1462-757f-481b-a9dc-f4019599d1df]
> Centralize all snapshot operations to SnapshotManager and cache snapshots
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-18111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18111
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Snapshots
> Reporter: Paulo Motta
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> Everytime {{nodetool listsnapshots}} is called, all data directories are
> scanned to find snapshots, what is inefficient.
> For example, fetching the
> {{org.apache.cassandra.metrics:type=ColumnFamily,name=SnapshotsSize}} metric
> can take half a second (CASSANDRA-13338).
> This improvement will also allow snapshots to be efficiently queried via
> virtual tables (CASSANDRA-18102).
> In order to do this, we should:
> a) load all snapshots from disk during initialization
> b) keep a collection of snapshots on {{SnapshotManager}}
> c) update the snapshots collection anytime a new snapshot is taken or cleared
> d) detect when a snapshot is manually removed from disk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
