[ 
https://issues.apache.org/jira/browse/CASSANDRA-19779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869579#comment-17869579
 ] 

Stefan Miklosovic commented on CASSANDRA-19779:
-----------------------------------------------

[CASSANDRA-19779-trunk|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19779-trunk]
{noformat}
java17_pre-commit_tests                         
  ✓ j17_build                                         4m 2s
  ✓ j17_cqlsh_dtests_py311                           6m 58s
  ✓ j17_cqlsh_dtests_py311_vnode                     7m 13s
  ✓ j17_cqlsh_dtests_py38                            6m 41s
  ✓ j17_cqlsh_dtests_py38_vnode                      6m 58s
  ✓ j17_cqlshlib_cython_tests                        7m 49s
  ✓ j17_cqlshlib_tests                               6m 33s
  ✓ j17_dtests                                      35m 10s
  ✓ j17_dtests_latest                               36m 14s
  ✓ j17_dtests_vnode                                 35m 9s
  ✓ j17_unit_tests                                  13m 42s
  ✓ j17_unit_tests_repeat                            3m 16s
  ✓ j17_utests_latest                                14m 8s
  ✓ j17_utests_latest_repeat                         2m 30s
  ✓ j17_utests_oa                                   14m 15s
  ✓ j17_utests_oa_repeat                             2m 31s
  ✕ j17_jvm_dtests                                  25m 23s
      
org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest 
testOptionalMtlsModeDoNotAllowNonSSLConnections
      
org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest 
testEndpointVerificationEnabledIpNotInSAN
  ✕ j17_jvm_dtests_latest_vnode                     25m 39s
      org.apache.cassandra.distributed.test.tcm.CMSPlacementAfterMoveTest 
testMoveToCMS                            
{noformat}

[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4554/workflows/588f442b-fb4d-4efd-9e48-4d16fb1c1da5]


> direct IO support is always evaluated to false upon the very first start of a 
> node
> ----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-19779
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19779
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Legacy/Tools
>            Reporter: Stefan Miklosovic
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 5.0-rc
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> When I extract the distribution tarball and I want to use tools in tools/bin, 
> there is this warn log visible every time for tools when they are started 
> (does not happen on "help" command, obviously)
> {code:java}
> WARN  14:25:11,835 Unable to determine block size for commit log directory: 
> null {code}
> This is because we introduced this (1) in CASSANDRA-18464
> What that does is that it will go and try to create a temporary file in 
> commit log directory to get "block size" for a "file store" that file is in.
> The problem with that is that when we just extract a tarball and run the 
> tools - Cassandra was never started - then such commit log directory does not 
> exist yet, so it tries to create a temporary file in a non-existing 
> directory, which fails, hence the log message.
> The fix is to check if commitlog dir exists and return / skip the resolution 
> of block size if it does not.
> Another approach might be to check if this is executed in the context of a 
> tool and skip it from resolution altogether. The problem with this is that 
> not all tools we have in bin/log call DatabaseDescriptor.
> toolInitialization() so we might combine these two.
> (1) 
> [https://github.com/apache/cassandra/blob/cassandra-5.0/src/java/org/apache/cassandra/config/DatabaseDescriptor.java#L1455-L1462]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to