michaelsembwever commented on code in PR #1787: URL: https://github.com/apache/cassandra-gocql-driver/pull/1787#discussion_r1704041200
########## CONTRIBUTING.md: ########## @@ -6,24 +6,39 @@ This guide outlines the process of landing patches in gocql and the general appr ## Background -The goal of the gocql project is to provide a stable and robust CQL driver for Go. gocql is a community driven project that is coordinated by a small team of core developers. +The goal of the gocql project is to provide a stable and robust CQL driver for Go. This is a community driven project that is coordinated by a small team of developers in and around the Apache Cassandra project. For security, governance and administration issues please refer to the Cassandra Project Management Committee. ## Minimum Requirement Checklist The following is a check list of requirements that need to be satisfied in order for us to merge your patch: -* You should raise a pull request to gocql/gocql on Github +* You should raise a pull request to apache/cassandra-gocql-driver on Github * The pull request has a title that clearly summarizes the purpose of the patch * The motivation behind the patch is clearly defined in the pull request summary -* Your name and email have been added to the `AUTHORS` file (for copyright purposes) +* You agree that your contribution is donated to the Apache Software Foundation (appropriate copyright is on all new files) * The patch will merge cleanly -* The test coverage does not fall below the critical threshold (currently 64%) -* The merge commit passes the regression test suite on Travis +* The test coverage does not fall +* The merge commit passes the regression test suite on GitHub Actions * `go fmt` has been applied to the submitted code * Notable changes (i.e. new features or changed behavior, bugfixes) are appropriately documented in CHANGELOG.md, functional changes also in godoc +* A correctly formatted commit message, see below If there are any requirements that can't be reasonably satisfied, please state this either on the pull request or as part of discussion on the mailing list. Where appropriate, the core team may apply discretion and make an exception to these requirements. +## Commit Message + +The Apache Cassandra project has a commit message precendence like +``` +<One sentence description, usually Jira title or CHANGES.txt summary> + + patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-##### +``` + +The 'patch by …; reviewed by' line is important. If enforces our review-than-commit procedure, allowing commits from non-git-branch patches, and is parsed to build the project contribulyse statistics found [here](https://nightlies.apache.org/cassandra/devbranch/misc/contribulyze/html/). Review Comment: Fixed. And a small rewording for clarify. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
