JeetKunDoug commented on code in PR #80:
URL:
https://github.com/apache/cassandra-analytics/pull/80#discussion_r1757005825
##########
cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/bulkwriter/token/TokenRangeMappingTest.java:
##########
@@ -105,16 +101,145 @@ void testCreateTokenRangeMappingWithPending()
}
TokenRangeMapping<RingInstance> topology = TokenRangeMapping.create(()
-> response,
()
-> Partitioner.Murmur3Partitioner,
- ()
-> rf, RingInstance::new);
+
RingInstance::new);
assertThat(topology.pendingInstances()).hasSize(pendingCount);
}
+ @Test
+ void testConsolidateListOfTokenRangeMappingFails()
Review Comment:
Is it possible to add some tests (or modify the replica building logic) to
cover the entire token range of the partitioner so we have wrap-around ranges
in these tests please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
