[ https://issues.apache.org/jira/browse/CASSANDRA-19448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881407#comment-17881407 ]
Stefan Miklosovic commented on CASSANDRA-19448: ----------------------------------------------- [CASSANDRA-19448-5.0|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19448-5.0] {noformat} java17_pre-commit_tests ✓ j17_build 4m 8s ✓ j17_cqlsh_dtests_py311 6m 7s ✓ j17_cqlsh_dtests_py311_vnode 6m 22s ✓ j17_cqlsh_dtests_py38 5m 58s ✓ j17_cqlsh_dtests_py38_vnode 6m 33s ✓ j17_cqlshlib_cython_tests 7m 41s ✓ j17_cqlshlib_tests 6m 29s ✓ j17_dtests 32m 42s ✓ j17_dtests_vnode 36m 10s ✓ j17_jvm_dtests 23m 55s ✓ j17_jvm_dtests_latest_vnode 13m 59s ✓ j17_unit_tests 16m 0s ✓ j17_unit_tests_repeat 9m 26s ✓ j17_utests_latest 18m 30s ✓ j17_utests_latest_repeat 9m 49s ✓ j17_utests_oa 16m 15s ✓ j17_utests_oa_repeat 9m 23s ✕ j17_dtests_latest 34m 5s bootstrap_test.TestBootstrap test_killed_wiped_node_cannot_join {noformat} [java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4722/workflows/81e88afe-66dc-4485-83d5-df9f43e07746] > CommitlogArchiver only has granularity to seconds for restore_point_in_time > --------------------------------------------------------------------------- > > Key: CASSANDRA-19448 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19448 > Project: Cassandra > Issue Type: Bug > Components: Local/Commit Log > Reporter: Jeremy Hanna > Assignee: Maxwell Guo > Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x > > Time Spent: 3h > Remaining Estimate: 0h > > Commitlog archiver allows users to backup commitlog files for the purpose of > doing point in time restores. The [configuration > file|https://github.com/apache/cassandra/blob/trunk/conf/commitlog_archiving.properties] > gives an example of down to the seconds granularity but then asks what > whether the timestamps are microseconds or milliseconds - defaulting to > microseconds. Because the [CommitLogArchiver uses a second based date > format|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogArchiver.java#L52], > if a user specifies to restore at something at a lower granularity like > milliseconds or microseconds, that means that the it will truncate everything > after the second and restore to that second. So say you specify a > restore_point_in_time like this: > restore_point_in_time=2024:01:18 17:01:01.623392 > it will silently truncate everything after the 01 seconds. So effectively to > the user, it is missing updates between 01 and 01.623392. > This appears to be a bug in the intent. We should allow users to specify > down to the millisecond or even microsecond level. If we allow them to > specify down to microseconds for the restore point in time, then it may > internally need to change from a long. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org