[ 
https://issues.apache.org/jira/browse/CASSANDRA-19960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885310#comment-17885310
 ] 

Stefan Miklosovic commented on CASSANDRA-19960:
-----------------------------------------------

[CASSANDRA-19960-5.0|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19960-5.0]
{noformat}
java17_separate_tests                            
  ✓ j17_build                                        4m 34s
  ✓ j17_unit_tests                                  18m 58s
  ✓ j17_unit_tests_repeat                            3m 54s
{noformat}

[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4833/workflows/ed341f0f-8644-4b64-b5a8-58b637fbdd05]


> CommitLogArchiver in CommitLog should be final (19448 follow-up)
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-19960
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19960
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/Commit Log
>            Reporter: Stefan Miklosovic
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> This is follow-up for CASSANDRA-19448, we made CommitLogArchiver non-final 
> but not volatile. This might cause issues. We just need to return it back to 
> final and remove the setter. The fact it is non-final now is because it was 
> more comfortable to write tests but there is not any reason to keep it like 
> that if tests are rewritten a little bit.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to