[ 
https://issues.apache.org/jira/browse/CASSANDRA-19902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17902483#comment-17902483
 ] 

Paulo Motta commented on CASSANDRA-19902:
-----------------------------------------

Thanks Marcus! Looks like there are some test failures on 5.0 patch:
 * [https://ci-cassandra.apache.org/job/Cassandra-devbranch-5/89/testReport/]

[RepairTest.testForcedNormalRepairWithOneNodeDown|https://ci-cassandra.apache.org/job/Cassandra-devbranch-5/89/testReport/org.apache.cassandra.distributed.test/RepairTest/Tests___jvm_dtest_jdk11_1_12___testForcedNormalRepairWithOneNodeDown__jdk11_x86_64/]
 looks to be tracked on CASSANDRA-18440

TriggersTest and RowCacheTest were calling StorageService.initServer multiple 
times causing this error when attempting to register StorageServiceMbean:
{code:none}
java.lang.RuntimeException: javax.management.InstanceAlreadyExistsException: 
org.apache.cassandra.db:type=StorageService
    at 
org.apache.cassandra.utils.MBeanWrapper$OnException.lambda$static$0(MBeanWrapper.java:365)
    at 
org.apache.cassandra.utils.MBeanWrapper$PlatformMBeanWrapper.registerMBean(MBeanWrapper.java:184)
    at 
org.apache.cassandra.utils.MBeanWrapper.registerMBean(MBeanWrapper.java:97)
    at 
org.apache.cassandra.utils.MBeanWrapper.registerMBean(MBeanWrapper.java:101)
    at 
org.apache.cassandra.service.StorageService.registerMBeans(StorageService.java:549)
Caused by: javax.management.InstanceAlreadyExistsException: 
org.apache.cassandra.db:type=StorageService
    at 
java.management/com.sun.jmx.mbeanserver.Repository.addMBean(Repository.java:436)
{code}
Updated these tests to call StorageService.initServer only once on 
@BeforeClass: 
[TriggersTest|https://github.com/pauloricardomg/cassandra/commit/5f5098413052baf08a256eac65b6efdbdfafa4fe],
 
[RowCacheTest|https://github.com/pauloricardomg/cassandra/commit/99b6b913f1636b08a81919c7ed68c6a309fd426b].

Also updated StorageService.registerMbeans to be idempotent (only log warning 
if Mbean is already registered): 
[commit|https://github.com/pauloricardomg/cassandra/commit/9af38834d62636568593c78f7d349b09c85b8f9c].

Submitted new 5.0 run: 
[https://ci-cassandra.apache.org/job/Cassandra-devbranch-5/91/]
also new trunk run with updates: 
[https://ci-cassandra.apache.org/job/Cassandra-devbranch-5/92/] (pending)

> StorageService JMX mbean is not available during bootstrap
> ----------------------------------------------------------
>
>                 Key: CASSANDRA-19902
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19902
>             Project: Apache Cassandra
>          Issue Type: Bug
>          Components: Tool/nodetool
>            Reporter: Paulo Motta
>            Assignee: Paulo Motta
>            Priority: Normal
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Looks like the seemingly harmless cosmetic patch from CASSANDRA-11537 causes 
> the StorageServiceMBean to not be available during bootstrap. This causes 
> commands like "nodetool nestats/status/etc" to not be available on the 
> boostrapping node with the following error:
> {code:none}
> - StackTrace --
> javax.management.InstanceNotFoundException: 
> org.apache.cassandra.db:type=StorageService
>         at 
> java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getMBean(DefaultMBeanServerInterceptor.java:1083)
>         at 
> java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:637)
> {code}
> This ticket is just to revert CASSANDRA-11537, we can re-add the improvement 
> of that ticket later.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to