[
https://issues.apache.org/jira/browse/CASSANDRA-18111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904456#comment-17904456
]
Stefan Miklosovic commented on CASSANDRA-18111:
-----------------------------------------------
[CASSANDRA-18111|https://github.com/instaclustr/cassandra/tree/CASSANDRA-18111]
{noformat}
java11_pre-commit_tests
✓ j11_build 8m 13s
✓ j11_cqlsh_dtests_py311 10m 22s
✓ j11_cqlsh_dtests_py311_vnode 8m 6s
✓ j11_cqlsh_dtests_py38 8m 30s
✓ j11_cqlsh_dtests_py38_vnode 11m 7s
✓ j11_cqlshlib_cython_tests 7m 58s
✓ j11_cqlshlib_tests 9m 56s
✓ j11_dtests 34m 46s
✓ j11_dtests_latest 36m 48s
✓ j11_jvm_dtests 31m 6s
✓ j11_simulator_dtests 9m 8s
✓ j11_unit_tests 21m 20s
✓ j11_utests_latest 17m 10s
✓ j11_utests_oa 17m 32s
✓ j11_utests_system_keyspace_directory 17m 44s
✓ j17_cqlsh_dtests_py311 7m 6s
✓ j17_cqlsh_dtests_py311_vnode 7m 36s
✓ j17_cqlsh_dtests_py38 7m 4s
✓ j17_cqlsh_dtests_py38_vnode 7m 25s
✓ j17_cqlshlib_cython_tests 10m 31s
✓ j17_cqlshlib_tests 6m 42s
✓ j17_dtests 32m 41s
✓ j17_dtests_latest 34m 58s
✓ j17_dtests_vnode 35m 44s
✓ j17_unit_tests 16m 49s
✓ j17_utests_oa 16m 56s
✕ j11_dtests_vnode 39m 24s
counter_test.TestCounters test_counter_node_down
✕ j11_jvm_dtests_latest_vnode 28m 43s
org.apache.cassandra.distributed.test.tcm.CMSPlacementAfterMoveTest
testMoveToCMS
✕ j17_jvm_dtests 27m 51s
org.apache.cassandra.fuzz.snapshots.SnapshotsTest fuzzySnapshotsTest
✕ j17_jvm_dtests_latest_vnode 25m 30s
org.apache.cassandra.distributed.test.tcm.CMSPlacementAfterMoveTest
testMoveToCMS
✕ j17_utests_latest 15m 54s
org.apache.cassandra.db.guardrails.GuardrailMaximumTimestampTest
testEnabledWarn
{noformat}
[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/5095/workflows/3d04b46e-ed2e-4eec-9847-ebbe2455b298]
I will be dealing with the stability of fuzzySnapshotsTest in a moment.
> Centralize all snapshot operations to SnapshotManager and cache snapshots
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-18111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18111
> Project: Apache Cassandra
> Issue Type: Improvement
> Components: Local/Snapshots
> Reporter: Paulo Motta
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 12h 40m
> Remaining Estimate: 0h
>
> Everytime {{nodetool listsnapshots}} is called, all data directories are
> scanned to find snapshots, what is inefficient.
> For example, fetching the
> {{org.apache.cassandra.metrics:type=ColumnFamily,name=SnapshotsSize}} metric
> can take half a second (CASSANDRA-13338).
> This improvement will also allow snapshots to be efficiently queried via
> virtual tables (CASSANDRA-18102).
> In order to do this, we should:
> a) load all snapshots from disk during initialization
> b) keep a collection of snapshots on {{SnapshotManager}}
> c) update the snapshots collection anytime a new snapshot is taken or cleared
> d) detect when a snapshot is manually removed from disk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
