[
https://issues.apache.org/jira/browse/CASSANDRA-20026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913448#comment-17913448
]
Caleb Rackliffe commented on CASSANDRA-20026:
---------------------------------------------
Got some [CI results|^ci_summary.html] from the trunk patch. Just a handful
of timeouts that don't look related to this patch, although something might be
going on with {{tools.nodetool.TableStatsTest#testMaybeChangeDocs}} around the
newly minted SAI bits like {{sai_local_query_latency_ms}}.
{noformat}
expected:<...o, twcs_max_duration[]) -t ,...> but was:<...o,
twcs_max_duration[, sai_local_query_latency_ms,
sai_post_filtering_read_latency, sai_disk_used_bytes, sai_sstable_indexes_hit,
sai_index_segments_hit sai_rows_filtered, sai_total_query_timeouts,
sai_total_queryable_index_ratio]) -t
,...>-junit.framework.AssertionFailedError: expected:<...o,
twcs_max_duration[]) -t ,...> but was:<...o, twcs_max_duration[,
sai_local_query_latency_ms, sai_post_filtering_read_latency,
sai_disk_used_bytes, sai_sstable_indexes_hit, sai_index_segments_hit
sai_rows_filtered, sai_total_query_timeouts, sai_total_queryable_index_ratio])
-t ,...> at
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
Method) at
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
at
java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
{noformat}
> Integrate SAI's index state and query performance metrics w/ nodetool
> tablestats
> --------------------------------------------------------------------------------
>
> Key: CASSANDRA-20026
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20026
> Project: Apache Cassandra
> Issue Type: Improvement
> Components: Feature/SAI, Tool/nodetool
> Reporter: Caleb Rackliffe
> Assignee: Sunil Ramchandra Pawar
> Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Attachments: ci_summary.html, nodetool tablestats output.png,
> result_details.tar.gz
>
>
> The output structure of {{nodetool tablestats}} might be amenable to adding a
> number of SAI state/performance metrics, which are predominantly
> table-scoped. (There are some that are scoped at the column level, of course,
> but the table-level items could be useful if we don't want to directly call
> JMX and want a general idea of how we're doing with things like
> post-filtering read latency.)
> The decisions we have to make are along the lines of "What percentile to use
> for post-filtering read latency?", but I imagine we can follow whatever
> existing pattern exists.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
