[ 
https://issues.apache.org/jira/browse/CASSANDRA-19947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922113#comment-17922113
 ] 

Sam Tunnicliffe commented on CASSANDRA-19947:
---------------------------------------------

I haven't properly reviewed the whole patch, but I did take a look at the 
places where it interacts with cluster metadata, specifically the serialization 
changes from adding constraints to ColumnMetadata. This looks fine after a 
couple of minor tweaks and I've done a few ad-hoc tests to verify things 
manually, but it would be nice to include some unit tests which exercise this a 
bit more rigorously e.g. some unit tests which round trip ser/deser of various 
permutations of columns/types/constraints.    

> CEP-42: Constraints Framework
> -----------------------------
>
>                 Key: CASSANDRA-19947
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19947
>             Project: Apache Cassandra
>          Issue Type: Improvement
>          Components: CQL/Syntax
>            Reporter: Bernardo Botella
>            Assignee: Bernardo Botella
>            Priority: Normal
>         Attachments: cep-42-with-constraints.html, ci_summary.html, 
> cpu_profile_cep42.html
>
>          Time Spent: 40h
>  Remaining Estimate: 0h
>
> Add new Constraints framework as described in CEP-42. This initial Jira 
> ticket includes the core constraints length and numeric. Follow up tickets 
> will include the rest of the constraints described in the CEP.
>  
> [https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-42%3A+Constraints+Framework]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to