[
https://issues.apache.org/jira/browse/CASSANDRA-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947938#comment-17947938
]
Jordan West commented on CASSANDRA-20551:
-----------------------------------------
note: benedicts +1 is on the PR itself
> ThreadLocalReadAheadBuffer shouldn't allocate on close if nothing is allocated
> ------------------------------------------------------------------------------
>
> Key: CASSANDRA-20551
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20551
> Project: Apache Cassandra
> Issue Type: Improvement
> Components: Local/Compaction
> Reporter: Jordan West
> Assignee: Jordan West
> Priority: Normal
> Fix For: 5.0.5
>
> Attachments: image-2025-04-15-16-59-14-067.png, screenshot-1.png
>
>
> Post the merge of CASSANDRA-15452 it was noticed that in
> {{ThreadLocalReadAheadBuffer#close()}} that we allocate a buffer even when
> not necessary. We can avoid this by not calling {{getBlock()}} and instead
> calling {{block()}} and returning early if the buffer is null.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
