[ https://issues.apache.org/jira/browse/CASSANDRA-20328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952612#comment-17952612 ]
Benedict Elliott Smith commented on CASSANDRA-20328: ---------------------------------------------------- I agree, we would ideally not depend on sstableloader in the Cassandra build as it creates a cyclic dependency. I think ant is pulling these classes in via the jars we build for sstableloader, in this part of build.xml: {code} <path id="cassandra.classpath"> <pathelement location="${build.classes.main}" /> <fileset dir="${build.dir.lib}"> <include name="**/*.jar" /> </fileset> </path> {code} The problem is we use this to import other non-cyclic dependencies, so not sure of the cleanest way to break this link. > Migrate sstableloader code to its own tools directory > ----------------------------------------------------- > > Key: CASSANDRA-20328 > URL: https://issues.apache.org/jira/browse/CASSANDRA-20328 > Project: Apache Cassandra > Issue Type: Improvement > Components: Tool/sstable > Reporter: Andy Tolbert > Assignee: Andy Tolbert > Priority: Normal > Labels: pull-request-available > Fix For: 5.x > > Attachments: CASSANDRA-0413-20328_ci_summary.html, > CASSANDRA-20328-511-0_ci_summary.html, CASSANDRA-20328-515-0_ci_summary.html, > CASSANDRA-20328-test_results.html, > ci_summary_tolbertam_CASSANDRA-20328_238.html, > results_details_tolbertam_CASSANDRA-20328_238.tar.xz > > Time Spent: 15h 10m > Remaining Estimate: 0h > > Akin to fqltool and stress, we should move sstableloader to its own tools > directory. This is needed to decouple the java driver as a dependency from > server code ([CASSANDRA-20326]). > For backwards compatibility reasons, we should retain {{bin/sstableloader}}. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org