[
https://issues.apache.org/jira/browse/CASSANDRA-20328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952782#comment-17952782
]
Benedict Elliott Smith edited comment on CASSANDRA-20328 at 5/20/25 7:17 AM:
-----------------------------------------------------------------------------
I am of the view that it is bad practice to have cyclic dependencies between
what are effectively modules. I don't think the fact it was done before is a
good reason, personally. That said, there's an argument to be made that dtests
should be treated as a cross-module test, and either way I don't think it's
something to agonise over extensively. But, personally, I would move the dtest
to a module/test/dtest directory if it weren't overly complicated to do so.
was (Author: benedict):
I am of the view that it is bad practice to have cyclic dependencies between
what are effectively modules. I don't think the fact it was done before is a
good reason, personally. That said, there's an argument to be made that dtests
should be treated as a cross-module test, and either way I don't think it's
something to agonise over extensively.
> Migrate sstableloader code to its own tools directory
> -----------------------------------------------------
>
> Key: CASSANDRA-20328
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20328
> Project: Apache Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
> Reporter: Andy Tolbert
> Assignee: Andy Tolbert
> Priority: Normal
> Labels: pull-request-available
> Fix For: 5.x
>
> Attachments: CASSANDRA-0413-20328_ci_summary.html,
> CASSANDRA-20328-511-0_ci_summary.html, CASSANDRA-20328-515-0_ci_summary.html,
> CASSANDRA-20328-515-0_results_details.tgz, CASSANDRA-20328-test_results.html,
> ci_summary_tolbertam_CASSANDRA-20328_238.html,
> results_details_tolbertam_CASSANDRA-20328_238.tar.xz
>
> Time Spent: 15h 10m
> Remaining Estimate: 0h
>
> Akin to fqltool and stress, we should move sstableloader to its own tools
> directory. This is needed to decouple the java driver as a dependency from
> server code ([CASSANDRA-20326]).
> For backwards compatibility reasons, we should retain {{bin/sstableloader}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
