[ 
https://issues.apache.org/jira/browse/CASSSIDECAR-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17985901#comment-17985901
 ] 

Francisco Guerrero commented on CASSSIDECAR-264:
------------------------------------------------

CI is green now 
https://app.circleci.com/pipelines/github/frankgh/cassandra-sidecar?branch=CASSSIDECAR-264

> Settings endpoint should return Service Unavailable when Cassandra instance 
> is down
> -----------------------------------------------------------------------------------
>
>                 Key: CASSSIDECAR-264
>                 URL: https://issues.apache.org/jira/browse/CASSSIDECAR-264
>             Project: Sidecar for Apache Cassandra
>          Issue Type: Bug
>          Components: Rest API
>            Reporter: Francisco Guerrero
>            Assignee: Francisco Guerrero
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> In CASSSIDECAR-182, a refactor was made to avoid performing null checks. 
> However, the 
> {{org.apache.cassandra.sidecar.cluster.CassandraAdapterDelegate#nodeSettings}}
>  method does not throw when {{nodeSettingsFromJmx}} is {{null}} even though 
> the method declares it throws when the information is unavailable.
> This can cause clients behave incorrectly when the expectation is a 503 - 
> Service Unavailable response.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to