[ 
https://issues.apache.org/jira/browse/CASSANDRA-3444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145342#comment-13145342
 ] 

Sylvain Lebresne commented on CASSANDRA-3444:
---------------------------------------------

I don't see 3437 v2 really addressing that in the sense that it seems to rename 
the method to invalidate, but since invalidate leaves the index unusable, I 
still can't see any reason for not clearing the indexes map in SIM a the end of 
invalidate. But it probably have no real consequence so far, I just think it 
would avoid future problems. And the main goal of this was to fix the test in 
trunk, which 3437 fixes too anyway, so I'm fine closing this.
                
> Secondary Index doesn't clean up indexed CFS on remove and Streaming test 
> failure.
> ----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3444
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3444
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Trivial
>             Fix For: 1.0.3
>
>         Attachments: 0001-clean-indexes-post-remove-and-streaming-tests.patch
>
>
> The initial reason for that issue is because StreamingTransferTest is broken 
> in trunk. It has been broken by CASSANDRA-3116 because the latter is too 
> efficient. More precisely StreamingTransferTest create a CF with an index, 
> then it calls unreferenceSSTables() on that CF to remove all sstable, and 
> then try a transfer (that recreate the file and index basically). But when 
> unreferenceSSTables() is called, it does fully remove the indexes in that the 
> CFS object for the indexes stays. Post CASSANDRA-3116, this is problem 
> because that CFS has been invalidated and thus nothing can be added back to 
> it.
> Long story short, I believe that the fact that 
> SecondaryIndexManager.removeAllIndex doesn't really unreference the CFS 
> objects is not expected in the first place. The patch fixes that and update 
> the StreamingTransferTest accordingly (fixing it as far as trunk is 
> concerned).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to